[PR] SettingToggle ~ Icon Support with fixes +new cfgs [#42] #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR: Add onAppear & Icon to a SettingToggle control [via mehdin13/Setting] on aheze/Setting
…sue via nillable horizontalPadding _ref aheze#42 This update fixes SettingToggle implementing Icons among other functionality - impl: edgePadding setter (optional) via env_var, otherwise uses horizontalPadding (default) - fixes: Icon padding issue (ref via nillable horizontalPadding (ref. aheze#38 (comment), covers aheze#38, aheze#37 - impl: SettingToggle extension supporting `.icon(...)` methods - impl: SettingToggle `onChange(...)` event handler, triggering when toggle is switched on/off
…ngToggle w. Icon + onChange(...) event _ref aheze#42 This change updates the Setting/SettingExample/PreferencesView showing how to use added icon support on SettingToggle, alongside the sample code which tracks toggle switch events and trigger onChange handler via closure Added Toggle switch example is rendered in "Extras" SettingGroup in "Preferences" tab: - SettingToggle `toggleIcon` (bool-based @AppStorage bindings) - SettingToggle `.icon(...)` example - SettingToggle `onChange(...)` example @duraki via _ref aheze#42
7 tasks
duraki
added a commit
to When-original-devs-wont-merge-good-PRs/Setting
that referenced
this pull request
Jan 26, 2025
…menu` _ref aheze#44 This small PR fixes bug in aheze#44 where the icon is not showing in SettingPicker component, when used in combination with `Setting.ChoicesConfiguration(pickerDisplayMode: .menu, ....)`: - Preappends `SettingIconView(...)` when using `.menu` picker's display mode - Requires merge of base PR @ aheze#43 & aheze#42 or cherry-picking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #42 and fixes #37, #38.
Relevant commits:
This update fixes SettingToggle implementing icon support among other functionality, along with adequate example code. Updates on SettingToggle for #42 includes:
.icon(...)methodsonChange(...)event handler, triggering when toggle is switched on/offtoggleIcon(bool-based https://github.com/AppStorage bindings).icon(...)exampleonChange(...)example