Remove build output from Nuget (#181)

* Remove build output from Nuget * fix warnings * fix morem warnings * merge projects * fix solution file * fix ref
agoda-com · Sep 8, 2023 · 5823478 · 5823478
1 parent e6b4931
commit 5823478
Show file tree

Hide file tree

Showing 62 changed files with 117 additions and 289 deletions.
diff --git a/src/Agoda.Analyzers.CodeFixes/Agoda.Analyzers.CodeFixes.csproj b/src/Agoda.Analyzers.CodeFixes/Agoda.Analyzers.CodeFixes.csproj
diff --git a/src/Agoda.Analyzers.CodeFixes/Agoda.Analyzers.nuspec b/src/Agoda.Analyzers.CodeFixes/Agoda.Analyzers.nuspec
diff --git a/src/Agoda.Analyzers.CodeFixes/Properties/AssemblyInfo.cs b/src/Agoda.Analyzers.CodeFixes/Properties/AssemblyInfo.cs
diff --git a/src/Agoda.Analyzers.CodeFixes/app.config b/src/Agoda.Analyzers.CodeFixes/app.config
diff --git a/src/Agoda.Analyzers.CodeFixes/tools/install.ps1 b/src/Agoda.Analyzers.CodeFixes/tools/install.ps1
diff --git a/src/Agoda.Analyzers.CodeFixes/tools/uninstall.ps1 b/src/Agoda.Analyzers.CodeFixes/tools/uninstall.ps1
diff --git a/src/Agoda.Analyzers.Test/Agoda.Analyzers.Test.csproj b/src/Agoda.Analyzers.Test/Agoda.Analyzers.Test.csproj
@@ -39,7 +39,6 @@
     </Content>
   </ItemGroup>
   <ItemGroup>
-    <ProjectReference Include="..\Agoda.Analyzers.CodeFixes\Agoda.Analyzers.CodeFixes.csproj" />
     <ProjectReference Include="..\Agoda.Analyzers\Agoda.Analyzers.csproj" />
   </ItemGroup>
   <ItemGroup>

diff --git a/src/Agoda.Analyzers.Test/AgodaCustom/AG0009UnitTests.cs b/src/Agoda.Analyzers.Test/AgodaCustom/AG0009UnitTests.cs
@@ -62,7 +62,6 @@ public TestClass(Microsoft.AspNetCore.Http.HttpContextAccessor context)
             new DiagnosticLocation(22, 23),
             new DiagnosticLocation(27, 22)
         };
-        HttpContextAccessor a;
         await VerifyDiagnosticsAsync(code, expected);
     }
 }
diff --git a/src/Agoda.Analyzers.Test/CodeFixes/AgodaCustom/AG0019FixProviderUnitTests.cs b/src/Agoda.Analyzers.Test/CodeFixes/AgodaCustom/AG0019FixProviderUnitTests.cs
@@ -1,5 +1,4 @@
 using Agoda.Analyzers.AgodaCustom;
-using Agoda.Analyzers.CodeFixes.AgodaCustom;
 using Agoda.Analyzers.Test.Helpers;
 using Microsoft.CodeAnalysis.CodeFixes;
 using Microsoft.CodeAnalysis.Diagnostics;

diff --git a/src/Agoda.Analyzers.Test/CodeFixes/AgodaCustom/AG0020FixProviderUnitTests.cs b/src/Agoda.Analyzers.Test/CodeFixes/AgodaCustom/AG0020FixProviderUnitTests.cs
@@ -4,7 +4,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Agoda.Analyzers.AgodaCustom;
-using Agoda.Analyzers.CodeFixes.AgodaCustom;
 using Agoda.Analyzers.Test.Helpers;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeFixes;

diff --git a/src/Agoda.Analyzers.Test/CodeFixes/AgodaCustom/AG0022FixProviderUnitTests.cs b/src/Agoda.Analyzers.Test/CodeFixes/AgodaCustom/AG0022FixProviderUnitTests.cs
@@ -5,7 +5,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Agoda.Analyzers.AgodaCustom;
-using Agoda.Analyzers.CodeFixes.AgodaCustom;
 using Agoda.Analyzers.Test.Helpers;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeFixes;

diff --git a/src/Agoda.Analyzers.Test/StyleCop/SA1106UnitTests.cs b/src/Agoda.Analyzers.Test/StyleCop/SA1106UnitTests.cs
@@ -1,7 +1,6 @@
 using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
-using Agoda.Analyzers.CodeFixes.StyleCop;
 using Agoda.Analyzers.StyleCop;
 using Agoda.Analyzers.Test.Helpers;
 using Microsoft.CodeAnalysis.CodeFixes;

diff --git a/src/Agoda.Analyzers.Test/StyleCop/SA1107UnitTests.cs b/src/Agoda.Analyzers.Test/StyleCop/SA1107UnitTests.cs
@@ -1,7 +1,6 @@
 using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
-using Agoda.Analyzers.CodeFixes.StyleCop;
 using Agoda.Analyzers.StyleCop;
 using Agoda.Analyzers.Test.Helpers;
 using Microsoft.CodeAnalysis;

diff --git a/src/Agoda.Analyzers.Test/StyleCop/SA1123UnitTests.cs b/src/Agoda.Analyzers.Test/StyleCop/SA1123UnitTests.cs
@@ -1,7 +1,6 @@
 using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
-using Agoda.Analyzers.CodeFixes.StyleCop;
 using Agoda.Analyzers.StyleCop;
 using Agoda.Analyzers.Test.Helpers;
 using Microsoft.CodeAnalysis.CodeFixes;

diff --git a/src/Agoda.Analyzers.Vsix/Agoda.Analyzers.Vsix.csproj b/src/Agoda.Analyzers.Vsix/Agoda.Analyzers.Vsix.csproj
@@ -58,14 +58,6 @@
     <Content Include="stylesheet.css" />
   </ItemGroup>
   <ItemGroup>
-    <ProjectReference Include="..\Agoda.Analyzers.CodeFixes\Agoda.Analyzers.CodeFixes.csproj">
-      <AdditionalProperties>TargetFramework=net472</AdditionalProperties>
-      <Project>{A5863784-CD41-4419-9C8F-53D89D509FE9}</Project>
-      <Name>Agoda.Analyzers.CodeFixes</Name>
-      <IncludeOutputGroupsInVSIX>BuiltProjectOutputGroup%3bBuiltProjectOutputGroupDependencies%3bGetCopyToOutputDirectoryItems%3bSatelliteDllsProjectOutputGroup%3b</IncludeOutputGroupsInVSIX>
-      <IncludeOutputGroupsInVSIXLocalOnly>DebugSymbolsProjectOutputGroup%3b</IncludeOutputGroupsInVSIXLocalOnly>
-      <Private>False</Private>
-    </ProjectReference>
     <ProjectReference Include="..\Agoda.Analyzers\Agoda.Analyzers.csproj">
       <AdditionalProperties>TargetFramework=net472</AdditionalProperties>
       <Project>{4F934D25-9BFF-4153-8965-F12F52BA41DF}</Project>

diff --git a/src/Agoda.Analyzers/Agoda.Analyzers.csproj b/src/Agoda.Analyzers/Agoda.Analyzers.csproj
@@ -8,12 +8,15 @@
     <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
+    <IncludeBuildOutput>false</IncludeBuildOutput>
+    <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
+	<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
   </PropertyGroup>
 	<PropertyGroup>
 		<Authors>Joel Dickson</Authors>
 		<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
 		<PackageProjectUrl>https://github.com/agoda-com/AgodaAnalyzers</PackageProjectUrl>
-		<PackageIconUrl>https://raw.githubusercontent.com/agoda-com/AgodaAnalyzers/master/AgodaAnalyzersAgoji.png</PackageIconUrl>
+		<PackageIcon>AgodaAnalyzersAgoji.png</PackageIcon>
 		<RepositoryUrl>https://github.com/agoda-com/AgodaAnalyzers</RepositoryUrl>
 		<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
 		<Description>A set of opinionated Roslyn analyzers for C#. This project is used by Agoda internally for analysis of our C# projects. We have opened it for community contribution and usage.</Description>
@@ -42,15 +45,16 @@
     </PackageReference>
     <PackageReference Include="Microsoft.CodeAnalysis.Common" Version="4.5.0" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.5.0" />
+    <PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.5.0" />
     <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
   </ItemGroup>
 	<ItemGroup>
 		<None Include="bin\Release\netstandard2.0\Agoda.Analyzers.dll" Pack="true" PackagePath="analyzers\dotnet\cs" Visible="false" />
 		<None Include="bin\Release\netstandard2.0\**\Agoda.Analyzers.resources.dll" Pack="true" PackagePath="analyzers\dotnet\cs" Visible="false" />
 		<None Include="bin\Release\netstandard2.0\Agoda.Analyzers.pdb" Pack="true" PackagePath="analyzers\dotnet\cs" Visible="false" />
-		<None Include="..\Agoda.Analyzers.CodeFixes\bin\Release\netstandard2.0\Agoda.Analyzers.CodeFixes.dll" Pack="true" PackagePath="analyzers\dotnet\cs" Visible="false" />
-		<None Include="..\Agoda.Analyzers.CodeFixes\bin\Release\netstandard2.0\**\Agoda.Analyzers.CodeFixes.resources.dll" Pack="true" PackagePath="analyzers\dotnet\cs" Visible="false" />
-		<None Include="..\Agoda.Analyzers.CodeFixes\bin\Release\netstandard2.0\Agoda.Analyzers.CodeFixes.pdb" Pack="true" PackagePath="analyzers\dotnet\cs" Visible="false" />
+		<Content Include="AgodaAnalyzersAgoji.png" Pack="true" PackagePath="">
+		  <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+		</Content>
 	</ItemGroup>
   <ItemGroup>
     <Compile Update="AgodaCustom\AG0018PermitOnlyCertainPubliclyExposedEnumerables.cs">

diff --git a/src/Agoda.Analyzers/AgodaAnalyzersAgoji.png b/src/Agoda.Analyzers/AgodaAnalyzersAgoji.png
diff --git a/src/Agoda.Analyzers/AgodaCustom/AG0002PrivateMethodsShouldNotBeTested.cs b/src/Agoda.Analyzers/AgodaCustom/AG0002PrivateMethodsShouldNotBeTested.cs
@@ -39,6 +39,8 @@ private static readonly LocalizableString Description
 
         public override void Initialize(AnalysisContext context)
         {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+            context.EnableConcurrentExecution();
             context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.MethodDeclaration);
         }
 

diff --git a/src/Agoda.Analyzers/AgodaCustom/AG0003HttpContextCannotBePassedAsMethodArgument.cs b/src/Agoda.Analyzers/AgodaCustom/AG0003HttpContextCannotBePassedAsMethodArgument.cs
@@ -43,6 +43,7 @@ public override void Initialize(AnalysisContext context)
         {
             context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
             context.EnableConcurrentExecution();
+            context.EnableConcurrentExecution();
 
             context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.Parameter);
         }

diff --git a/src/Agoda.Analyzers/AgodaCustom/AG0004DoNotUseHardCodedStringsToIdentifyTypes.cs b/src/Agoda.Analyzers/AgodaCustom/AG0004DoNotUseHardCodedStringsToIdentifyTypes.cs
@@ -41,6 +41,8 @@ public class AG0004DoNotUseHardCodedStringsToIdentifyTypes : DiagnosticAnalyzer
 
         public override void Initialize(AnalysisContext context)
         {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+            context.EnableConcurrentExecution();
             context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.InvocationExpression);
         }
 

diff --git a/src/Agoda.Analyzers/AgodaCustom/AG0005TestMethodNamesMustFollowConvention.cs b/src/Agoda.Analyzers/AgodaCustom/AG0005TestMethodNamesMustFollowConvention.cs
@@ -43,6 +43,8 @@ public class AG0005TestMethodNamesMustFollowConvention : DiagnosticAnalyzer
 
         public override void Initialize(AnalysisContext context)
         {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+            context.EnableConcurrentExecution();
             context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.MethodDeclaration);
         }
 

diff --git a/...a.Analyzers/AgodaCustom/AG0006RegisteredComponentShouldHaveExactlyOnePublicConstructor.cs b/...a.Analyzers/AgodaCustom/AG0006RegisteredComponentShouldHaveExactlyOnePublicConstructor.cs
@@ -42,6 +42,8 @@ public class AG0006RegisteredComponentShouldHaveExactlyOnePublicConstructor : Di
 
         public override void Initialize(AnalysisContext context)
         {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+            context.EnableConcurrentExecution();
             context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.ClassDeclaration);
         }
 

diff --git a/src/Agoda.Analyzers/AgodaCustom/AG0009IHttpContextAccessorCannotBePassedAsMethodArgument.cs b/src/Agoda.Analyzers/AgodaCustom/AG0009IHttpContextAccessorCannotBePassedAsMethodArgument.cs
@@ -53,6 +53,7 @@ public override void Initialize(AnalysisContext context)
         {
             context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
             context.EnableConcurrentExecution();
+            context.EnableConcurrentExecution();
 
             context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.Parameter);
         }

diff --git a/src/Agoda.Analyzers/AgodaCustom/AG0010PreventTestFixtureInheritance.cs b/src/Agoda.Analyzers/AgodaCustom/AG0010PreventTestFixtureInheritance.cs
@@ -40,6 +40,8 @@ public class AG0010PreventTestFixtureInheritance : DiagnosticAnalyzer
 
         public override void Initialize(AnalysisContext context)
         {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+            context.EnableConcurrentExecution();
             context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.ClassDeclaration);
         }
 

diff --git a/src/Agoda.Analyzers/AgodaCustom/AG0012TestMethodMustContainAtLeastOneAssertion.cs b/src/Agoda.Analyzers/AgodaCustom/AG0012TestMethodMustContainAtLeastOneAssertion.cs
@@ -49,6 +49,8 @@ private static readonly LocalizableString Description
 
         public override void Initialize(AnalysisContext context)
         {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+            context.EnableConcurrentExecution();
             context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.MethodDeclaration);
         }