Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recipes bug #319

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Fix recipes bug #319

merged 2 commits into from
Jul 21, 2024

Conversation

Eternal130
Copy link
Contributor

Re-add recipes that were mistakenly not added; Modify recipes of LED vuMeter and Analog vuMeter to allow crafting with all types of planks instead of just 4 types; Add recipes for the following items: Voltage controlled amplifier, Thermistor, Low Current Relay, Medium Current Relay, High Current Relay, Multicolor LED vuMeter, Rolling Shaft Machine, Crank Shaft, Animal Filter, Christmas Tree (only available during Christmas), Holiday Candle (only available during Christmas), String Lights (only available during Christmas)

…y recipes of LED vuMeter and Analog vuMeter to allow crafting with all types of planks instead of just 4 types; Add recipes for the following items: Voltage controlled amplifier, Thermistor, Low Current Relay, Medium Current Relay, High Current Relay, Multicolor LED vuMeter, Rolling Shaft Machine, Crank Shaft, Animal Filter, Christmas Tree (only available during Christmas), Holiday Candle (only available during Christmas), String Lights (only available during Christmas)
Copy link
Collaborator

@jrddunbr jrddunbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things here and there. Overall, pretty awesome, thanks! Sorry for the delayed response.

@jrddunbr
Copy link
Collaborator

Also, mildly curious what line fixes the bug; was it just macerator recipes I broke? Probably related: #314

@jrddunbr jrddunbr added bug A bug has been found! enhancement playtest This pull request needs to be tested before ready labels Mar 29, 2024
@jrddunbr jrddunbr added this to the 1.22.x milestone Mar 29, 2024
@Eternal130
Copy link
Contributor Author

Also, mildly curious what line fixes the bug; was it just macerator recipes I broke? Probably related: #314

9be406a
In this commit, you transferred the recipes registration to CraftingRecipes.kt, but did not call the relevant methods in Eln.java

@Eternal130 Eternal130 requested a review from jrddunbr April 9, 2024 14:27
@jrddunbr jrddunbr merged commit 04e217b into age-series:1.22.x Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug has been found! enhancement playtest This pull request needs to be tested before ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants