Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aens): don't require name ttl in name extend #245

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Apr 9, 2024

closes #224

This PR is supported by the Æternity Foundation

@davidyuk davidyuk added this to the v6.0.0 milestone Apr 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (797186c) to head (0d4aa51).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #245      +/-   ##
===========================================
- Coverage    92.98%   92.98%   -0.01%     
===========================================
  Files           24       24              
  Lines         2794     2793       -1     
===========================================
- Hits          2598     2597       -1     
  Misses         196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk requested a review from thepiwo April 10, 2024 06:09
Copy link
Contributor

@thepiwo thepiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't check in detail, but overall looks really good!

@davidyuk davidyuk merged commit da8b4e6 into develop Apr 11, 2024
1 check passed
@davidyuk davidyuk deleted the feature/optional-name-ttl branch April 11, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make nameTtl in name extend optional and default to the maximum value (NAME_TTL, 180000)
3 participants