Skip to content

refactor(account)!: move aecli account spend to aecli spend #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Apr 9, 2024

closes #222

This PR is supported by the Æternity Foundation

@davidyuk davidyuk added this to the v6.0.0 milestone Apr 9, 2024
@davidyuk davidyuk force-pushed the feature/refactor-spend branch 3 times, most recently from 38c1355 to 17e1203 Compare April 10, 2024 07:07
BREAKING CHANGE: `aecli account spend` renamed to `aecli spend`
@davidyuk davidyuk force-pushed the feature/refactor-spend branch from 17e1203 to 4af1b4c Compare April 10, 2024 07:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.96%. Comparing base (797186c) to head (929c78c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #244      +/-   ##
===========================================
- Coverage    92.98%   92.96%   -0.02%     
===========================================
  Files           24       25       +1     
  Lines         2794     2787       -7     
===========================================
- Hits          2598     2591       -7     
  Misses         196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk requested a review from thepiwo April 10, 2024 07:18
Copy link
Contributor

@thepiwo thepiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked at a single commit by accident before,

overall didn't check in detail, but overall looks really good!

@davidyuk davidyuk merged commit 12bb2b7 into develop Apr 11, 2024
1 check passed
@davidyuk davidyuk deleted the feature/refactor-spend branch April 11, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put spend to the root, extract it from accounts
3 participants