Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Type.filter_inplace #1261

Closed
brandonwillard opened this issue Oct 16, 2022 Discussed in #1248 · 1 comment
Closed

Remove Type.filter_inplace #1261

brandonwillard opened this issue Oct 16, 2022 Discussed in #1248 · 1 comment
Labels
duplicate This issue or pull request already exists refactor This issue involves refactoring
Milestone
Clean up after Th...

Comments

@brandonwillard
Copy link
Member

Discussed in #1248

Originally posted by markusschmaus October 10, 2022
Type.filter_inplace is currently not implemented anywhere in the code and the only place where it is used the NotImplementedError is caught and Type.filter is used instead. Based on the comment it seems that this is some leftover from some earlier feature. Is there any reason why this should be kept around? Otherwise I am going to remove it in #1207.
@brandonwillard brandonwillard added the refactor This issue involves refactoring label Oct 16, 2022
@brandonwillard brandonwillard added this to the Clean up after Theano milestone Oct 16, 2022
@ricardoV94
Copy link
Contributor

Closing this as duplicate of #1250

@ricardoV94 ricardoV94 added the duplicate This issue or pull request already exists label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists refactor This issue involves refactoring
Projects
None yet
Milestone
Clean up after Theano
Development

No branches or pull requests
2 participants
@brandonwillard @ricardoV94