Skip to content

Commit

Permalink
fix linter complaints
Browse files Browse the repository at this point in the history
  • Loading branch information
dwelch-spike committed Dec 2, 2024
1 parent fe54c12 commit 39a72fc
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 4 deletions.
18 changes: 15 additions & 3 deletions cmd/writers/nodeList.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,17 @@ func NewNodeTableWriter(writer io.Writer, isLB bool, logger *slog.Logger) *NodeT
t := NodeTableWriter{NewDefaultWriter(writer), isLB, logger}

t.table.SetTitle("Nodes")
t.table.AppendHeader(table.Row{"Node", "Roles", "Endpoint", "Cluster ID", "Version", "Visible Nodes"}, rowConfigAutoMerge)
t.table.AppendHeader(
table.Row{
"Node",
"Roles",
"Endpoint",
"Cluster ID",
"Version",
"Visible Nodes",
},
rowConfigAutoMerge,
)
t.table.SetAutoIndex(true)
t.table.SortBy([]table.SortBy{
{Name: "Node", Mode: table.Asc},
Expand Down Expand Up @@ -59,8 +69,10 @@ func (itw *NodeTableWriter) AppendNodeRow(node *NodeInfo) {
row = append(row, id)
}

row = append(row, formatRoles(node.About.GetRoles()))
row = append(row, formatEndpoint(node.ConnectedEndpoint))
row = append(row,
formatRoles(node.About.GetRoles()),
formatEndpoint(node.ConnectedEndpoint),
)

if node.State != nil {
row = append(row, node.State.ClusterId.GetId())
Expand Down
8 changes: 7 additions & 1 deletion cmd/writers/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,13 @@ func Test_formatRoles(t *testing.T) {
}{
{
name: "TestMultipleRoles",
args: args{roles: []protos.NodeRole{protos.NodeRole_INDEX_QUERY, protos.NodeRole_INDEX_UPDATE, protos.NodeRole_KV_READ}},
args: args{
roles: []protos.NodeRole{
protos.NodeRole_INDEX_QUERY,
protos.NodeRole_INDEX_UPDATE,
protos.NodeRole_KV_READ,
},
},
want: []string{"INDEX_QUERY", "INDEX_UPDATE", "KV_READ"},
},
{
Expand Down

0 comments on commit 39a72fc

Please sign in to comment.