Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: OLPSUP-10887 Add support for multiple HWIDs #738

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkfu
Copy link
Collaborator

@tkfu tkfu commented Jun 24, 2020

A software image can be compatible with several different hardware IDs, because different hardware IDs can have the same MACHINE value.

WIP, not yet tested, DNM, etc.

Signed-off-by: Jon Oster <jon.oster@here.com>
@tkfu
Copy link
Collaborator Author

tkfu commented Jun 24, 2020

Note: I realize that I still need to implement a check for invalid characters in GARAGE_TARGET_COMPATIBLE_HWIDS, but if this general approach is ok that should be a pretty quick fix.

@pattivacek
Copy link
Collaborator

Looks fine, we should just test thoroughly to make sure it really does what we think it does. I wish we could reuse an existing variables, but it looks like both SOTA_HARDWARE_ID and OSTREE_BRANCHNAME won't work, so this is fine. If we merge this, let's not forget to update https://docs.ota.here.com/ota-client/latest/build-configuration.html#_configuration_variables_in_meta_updater, too.

@pattivacek
Copy link
Collaborator

CI failure is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants