Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid null error on some parent job types (e.g AQA_Test_Pipeline) #963

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

YosiElias
Copy link
Contributor

This PR fixes null error when accessing parenttokens. The error occurs for certain types of parent jobs where the buildName does not match the expected pattern (e.g AQA_Test_Pipeline)

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for eclipsefdn-adoptium-trss canceled.

Name Link
🔨 Latest commit 4fd3746
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-trss/deploys/679b567d7d24090008d35fea

@smlambert smlambert requested a review from llxia January 29, 2025 14:56
@smlambert
Copy link
Contributor

Thanks @YosiElias - can you sign the Eclipse Committer Agreement (ECA), that is needed in order to contribute to any of the 400+ open-source projects that are part of the Eclipse Foundation - more info here: https://adoptium.net/docs/eca-sign-off/

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YosiElias YosiElias force-pushed the issue816_small-fix branch 2 times, most recently from c4572d2 to 414ccd2 Compare January 30, 2025 10:36
…ypes

Signed-off-by: YosiElias <yosielias@outlook.com>
@YosiElias YosiElias requested a review from llxia January 30, 2025 10:46
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @YosiElias !

@smlambert smlambert merged commit a7a6b4d into adoptium:master Jan 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants