Add new admin access for orgs and profile #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresbott
approved these changes
Apr 18, 2024
| // given access token. It returns a non-nil response on success or an error on | ||
| // failure. | ||
| func (c *Client) GetAdminOrganizationsWithContext(ctx context.Context, r *GetAdminOrganizationsRequest) (*GetAdminOrganizationsResponse, error) { | ||
| if r.ApiVersion == "" { |
There was a problem hiding this comment.
does it make sense to expose the API version? i assume every version will have a different payload, hence, a different version would need to be supported by the method.
There was a problem hiding this comment.
I think it does.
The changes between versions are generally small and transparent to the purpose of the library. Changes like adding a new value or a new field don't need new support and it is practical for the clients to update their API version used easily as they need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access profile and organization admin APIs using a service token