-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
login-signup-auth #574
login-signup-auth #574
Conversation
✅ Deploy Preview for pathsphere ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@saras-69 have you made the changes i told you |
@aditya-bhaumik What changes you want |
Go and check the issue |
Already told long back |
I appreciate your feedback about improving the UI. Could you please share some design suggestions from Figma? It would be really helpful to see what you have in mind. |
My main focus was on implementing the authentication logic and ensuring a user-friendly experience, which is why I kept the UI simple. However, if you have any design suggestions from Figma, I’d be happy to incorporate them. |
But i did not give any feedback regarding ui |
Your code is removing the hamburger icon from the mobile view which is already there |
I just told you to fix it |
Hey @aditya-bhaumik Since my focus was on authentication logic and user-friendliness, I kept the UI minimal. If this gets merged, a UI designer can further enhance it later. Let me know your thoughts🫠 |
I cant merge this as this code is introducing a new bug |
Take help from someone in discord if you are not able to understand what i am trying to say |
You can explain me on discord I'm in your DM |
|
@saras-69 press on commit suggestion then the work is done |
I will merge the pr |
I was trying to help you get a github badge |
You had to press on commit suggestion not make a separate commit |
Just press on it and commit changes |
Just press on commit suggestion |
Dont make a separate commit of ur own |
Co-authored-by: Aditya Bhaumik <92214013+aditya-bhaumik@users.noreply.github.com>
Thank you for merging my pull request and adding the labels! I appreciate your support! |
Closes: #116
Summary
This PR adds complete Login/Signup functionality with backend authentication and Password Recovery modal. It includes form validation, password toggling, and smooth animations for tab switching.
Changes
Login and Signup Pages:
Form validations for email and password.
Smooth tab switching between Login/Signup.
Password visibility toggle using icons.
Login status stored using localStorage.
Redirect to specific pages upon login (e.g., scholarships).
Password Recovery:
A modal for password recovery with form validation.
Simulates sending a recovery email with visual feedback.
Smooth open/close transitions for the modal.
Types of Changes
New feature (adds functionality)
Refactoring (UI/UX improvements)
Checklist
Code follows the project’s style guidelines.
Self-reviewed and commented where necessary.
No new warnings or system breaks.
Relevant tests added and passing.