Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login-signup-auth #574

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Conversation

saras-69
Copy link
Contributor

@saras-69 saras-69 commented Oct 12, 2024

Closes: #116
Summary
This PR adds complete Login/Signup functionality with backend authentication and Password Recovery modal. It includes form validation, password toggling, and smooth animations for tab switching.

Changes
Login and Signup Pages:

Form validations for email and password.
Smooth tab switching between Login/Signup.
Password visibility toggle using icons.
Login status stored using localStorage.
Redirect to specific pages upon login (e.g., scholarships).
Password Recovery:

A modal for password recovery with form validation.
Simulates sending a recovery email with visual feedback.
Smooth open/close transitions for the modal.
Types of Changes
New feature (adds functionality)
Refactoring (UI/UX improvements)
Checklist
Code follows the project’s style guidelines.
Self-reviewed and commented where necessary.
No new warnings or system breaks.
Relevant tests added and passing.

Screenshot 2024-10-13 024547
Screenshot 2024-10-13 024555
Screenshot 2024-10-13 024607
Screenshot 2024-10-13 024643
Screenshot 2024-10-13 024658

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for pathsphere ready!

Name Link
🔨 Latest commit d8c46e3
🔍 Latest deploy log https://app.netlify.com/sites/pathsphere/deploys/670cf09e4d213a0009214361
😎 Deploy Preview https://deploy-preview-574--pathsphere.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aditya-bhaumik
Copy link
Owner

@saras-69 have you made the changes i told you

@saras-69
Copy link
Contributor Author

@aditya-bhaumik What changes you want

@aditya-bhaumik
Copy link
Owner

Go and check the issue

@aditya-bhaumik
Copy link
Owner

Already told long back

@saras-69
Copy link
Contributor Author

Already told long back

I appreciate your feedback about improving the UI. Could you please share some design suggestions from Figma? It would be really helpful to see what you have in mind.

@saras-69
Copy link
Contributor Author

My main focus was on implementing the authentication logic and ensuring a user-friendly experience, which is why I kept the UI simple. However, if you have any design suggestions from Figma, I’d be happy to incorporate them.

@aditya-bhaumik
Copy link
Owner

But i did not give any feedback regarding ui

@aditya-bhaumik
Copy link
Owner

Your code is removing the hamburger icon from the mobile view which is already there

@aditya-bhaumik
Copy link
Owner

I just told you to fix it

@saras-69
Copy link
Contributor Author

Hey @aditya-bhaumik Since my focus was on authentication logic and user-friendliness, I kept the UI minimal. If this gets merged, a UI designer can further enhance it later. Let me know your thoughts🫠

@aditya-bhaumik
Copy link
Owner

I cant merge this as this code is introducing a new bug

@aditya-bhaumik
Copy link
Owner

Take help from someone in discord if you are not able to understand what i am trying to say

@saras-69
Copy link
Contributor Author

You can explain me on discord I'm in your DM

@saras-69
Copy link
Contributor Author

I cant merge this as this code is introducing a new bug
Could you please share more details about the bug you're encountering?

@saras-69
Copy link
Contributor Author

Screenshot 2024-10-13 225926
Screenshot 2024-10-13 230613

@aditya-bhaumik
Copy link
Owner

@saras-69 press on commit suggestion then the work is done

@aditya-bhaumik
Copy link
Owner

I will merge the pr

@aditya-bhaumik
Copy link
Owner

I was trying to help you get a github badge

@aditya-bhaumik
Copy link
Owner

You had to press on commit suggestion not make a separate commit

@aditya-bhaumik
Copy link
Owner

Just press on it and commit changes

@aditya-bhaumik
Copy link
Owner

Just press on commit suggestion

@aditya-bhaumik
Copy link
Owner

Dont make a separate commit of ur own

Co-authored-by: Aditya Bhaumik <92214013+aditya-bhaumik@users.noreply.github.com>
@aditya-bhaumik
Copy link
Owner

image

@aditya-bhaumik aditya-bhaumik merged commit 8bdcc40 into aditya-bhaumik:main Oct 14, 2024
1 check passed
@saras-69
Copy link
Contributor Author

Thank you for merging my pull request and adding the labels! I appreciate your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Login/Signup Component with "Forgot Password" Authentication
2 participants