added a DBAL-column lazy-loading cache to entity-mapping

addiks · Jan 22, 2021 · 1882799 · 1882799
1 parent a8bc4c8
commit 1882799
Showing 1 changed file with 16 additions and 9 deletions.
diff --git a/Mapping/EntityMapping.php b/Mapping/EntityMapping.php
@@ -37,6 +37,9 @@ final class EntityMapping implements EntityMappingInterface
      */
     private $fieldMappings = array();
 
+    /** @var array<Column>|null */
+    private $dbalColumnsCache;
+
     /** @param class-string $className */
     public function __construct(string $className, array $fieldMappings)
     {
@@ -78,19 +81,23 @@ public function describeOrigin(): string
 
     public function collectDBALColumns(): array
     {
-        /** @var array<Column> $additionalColumns */
-        $additionalColumns = array();
+        if (is_null($this->dbalColumnsCache)) {
+            /** @var array<Column> $additionalColumns */
+            $additionalColumns = array();
 
-        foreach ($this->fieldMappings as $fieldMapping) {
-            /** @var MappingInterface $fieldMapping */
+            foreach ($this->fieldMappings as $fieldMapping) {
+                /** @var MappingInterface $fieldMapping */
+
+                $additionalColumns = array_merge(
+                    $additionalColumns,
+                    $fieldMapping->collectDBALColumns()
+                );
+            }
 
-            $additionalColumns = array_merge(
-                $additionalColumns,
-                $fieldMapping->collectDBALColumns()
-            );
+            $this->dbalColumnsCache = $additionalColumns;
         }
 
-        return $additionalColumns;
+        return $this->dbalColumnsCache;
     }
 
     public function getFactory(): ?CallDefinitionInterface