Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: clean_url fails on apostrophe in urls #106

Closed
mikewolfd opened this issue Jun 23, 2024 · 1 comment · Fixed by #107
Closed

Bug: clean_url fails on apostrophe in urls #106

mikewolfd opened this issue Jun 23, 2024 · 1 comment · Fixed by #107
Labels

Comments

@mikewolfd
Copy link

The clean_url function fails when a URL contains an apostrophe. I tried to quote/encode the URL, but it wouldn't parse & clean it correctly.

The clean_url function should accept escaped/encoded URLs or better handle characters such as an apostrophe.

@mikewolfd mikewolfd changed the title Fails on apostrophe in urls Bug: clean_url fails on apostrophe in urls Jun 23, 2024
@adbar adbar added the bug label Jun 27, 2024
@adbar
Copy link
Owner

adbar commented Jun 27, 2024

Thanks for your feedback, there seems to be a problem indeed, the cleaning component stops at an apostrophe and returns what was before.

@adbar adbar linked a pull request Jul 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants