Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range selection #2865

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

hadyelzayady
Copy link

@hadyelzayady hadyelzayady commented Mar 26, 2022

Range selection with a mouse or shift+arrows.
copy and paste are handled.
group rows are not handled.
auto-scroll on range selection will be handled soon

Screen.Recording.2022-03-26.at.11.19.41.AM.mov

#2753 #2260

@babakansari
Copy link

Hi @hadyelzayady,

Any ballpark when could this feature become available for public use? Thanks!

cc @amanmahajan7 , @nstepien

@farooq7124
Copy link

Hi @amanmahajan7

Request you to please review this feature and make it available for users

Thanks

@adityatoshniwal
Copy link

HI @hadyelzayady,

An improvement could be - When using shift + arrow on row selection checkbox, it will change the selection of complete row and not just the row selection box.

@jmjuanico
Copy link

@hadyelzayady @amanmahajan7 looking forward to have this available. thanks.

@ecoant
Copy link

ecoant commented Oct 3, 2022

Is anyone maintaining this project concerned with bringing this PR in? Would be really great to have the same features we already had in v5, I assumed upgrading would bring me an improved experience, not one where a major feature of excel-like data grids was dropped. @nstepien @amanmahajan7

@damnitrahul
Copy link

Hey @nstepien @amanmahajan7

Request you to please review this and consider merging it.

@damnitrahul
Copy link

Hey, @nstepien @amanmahajan7
Any thoughts on merging this?

@DVGY
Copy link

DVGY commented Jul 2, 2023

Need this feature ASAP

@pikpok
Copy link

pikpok commented Sep 6, 2023

@hadyelzayady I've rebased your PR on top of current main and modified it to allow selection of multiple ranges. It's hacky, but works good enough for my usecase. It's available here, and released as @pikpok/react-data-grid.
If you don't have anything against it and don't want to take care of this topic anymore, I can try to make it into a better state and submit a new PR. I see that there's some interest in getting this feature merged 🙂

@hadyelzayady
Copy link
Author

@pikpok That is fine, I lost interest anyway despite having other features in my mind back then

@DVGY
Copy link

DVGY commented Sep 7, 2023

@pikpok That is fine, I lost interest anyway despite having other features in my mind back then

Lol.

adamerose added a commit to adamerose/jsgrids that referenced this pull request Sep 15, 2023
statico pushed a commit to statico/jsgrids that referenced this pull request Oct 9, 2023
@IrakliJani
Copy link

IrakliJani commented Mar 30, 2024

@holaChaitanya
Copy link

Hey, @nstepien @amanmahajan7
Any thoughts on merging this?

@sayers
Copy link

sayers commented Jul 3, 2024

@pikpok would you mind tidying up your fork and getting a PR up for multi select? Lots of people want this feature.

@adityatoshniwal
Copy link

We forked rdg and applied this PR (with some required changes) to use for pgAdmin here - https://github.com/pgadmin-org/react-data-grid. The latest commit is adding the range selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.