Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canary.10 and newer: Cell Range Selection not working anymore #1930

Closed
3 of 11 tasks
gernotkogler opened this issue Jan 30, 2020 · 7 comments
Closed
3 of 11 tasks

canary.10 and newer: Cell Range Selection not working anymore #1930

gernotkogler opened this issue Jan 30, 2020 · 7 comments

Comments

@gernotkogler
Copy link

gernotkogler commented Jan 30, 2020

  • Have you already searched for similar issues? Please help us out and double-check first!

  • Also, please don't be that person who deletes this template. It's here for a reason.

  • Thanks!


Which version of React JS are you using?

✅ Officially supported ✅

  • v15.4.x

⚠️ Not officially supported, expect warnings ⚠️

  • v15.5.x
  • v15.6.x

☣️ Not officially supported, expect warnings and errors ☣️

  • v16.x.x

Which browser are you using?

✅ Officially supported ✅

  • IE 9 / IE 10 / IE 11
  • Edge
  • Chrome

⚠️ Not officially supported, but "should work" ⚠️

  • Firefox
  • Safari

I'm submitting a ...

  • 🐛 Bug Report
  • 💡 Feature Request

👋 Need general support? Not sure about how to use React itself, or how to get started with the Grid?
Please do not submit a support request here. Instead see

https://github.com/adazzle/react-data-grid/blob/master/docs/CONTRIBUTING.md


Issue Details

Please include:
- What the current behavior is
- What the desired behavior is
- (If Bug) Steps to reproduce the issue
- (If Feature) The motivation / use case for the feature

We especially love screenshots / videos of problems, and remember
The Best Issue Is A Pull Request™

Since canary.10, I cannot select a range of cells by mouse or keyboard anymore. I noticed that canary.10 introduced an new API and I adopted it, but I cannot find an option to activate cell range selection, which obviously is now disabled by default.

What am I missing?

@maestroAlfredo
Copy link

  • Have you already searched for similar issues? Please help us out and double-check first!
  • Also, please don't be that person who deletes this template. It's here for a reason.
  • Thanks!

Which version of React JS are you using?

✅ Officially supported ✅

  • v15.4.x

⚠️ Not officially supported, expect warnings ⚠️

  • v15.5.x
  • v15.6.x

☣️ Not officially supported, expect warnings and errors ☣️

  • v16.x.x

Which browser are you using?

✅ Officially supported ✅

  • IE 9 / IE 10 / IE 11
  • Edge
  • Chrome

⚠️ Not officially supported, but "should work" ⚠️

  • Firefox
  • Safari

I'm submitting a ...

  • 🐛 Bug Report
  • 💡 Feature Request

👋 Need general support? Not sure about how to use React itself, or how to get started with the Grid?
Please do not submit a support request here. Instead see

https://github.com/adazzle/react-data-grid/blob/master/docs/CONTRIBUTING.md

Issue Details

Please include:
- What the current behavior is
- What the desired behavior is
- (If Bug) Steps to reproduce the issue
- (If Feature) The motivation / use case for the feature

We especially love screenshots / videos of problems, and remember
The Best Issue Is A Pull Request™

Since canary.10, I cannot select a range of cells by mouse or keyboard anymore. I noticed that canary.10 introduced an new API and I adopted it, but I cannot find an option to activate cell range selection, which obviously is now disabled by default.

What am I missing?

Same issue here. I see the SelectionRangeMasks have been removed. Are there any plans to bring this back?

@farooq7124
Copy link

Hi Team,

Any plans to update on Cell range selection. I tried below config it is not working. it is very need feature as part of providing EXCEL sheet.

cellRangeSelection={{
onStart: args => console.log(rows),
onUpdate: args => console.log(rows),
onComplete: args => console.log(rows)
}}

Thanks team for great component

@ake2l
Copy link

ake2l commented Jun 11, 2020

Hi Team,
same wish to get this feature back , here :)

What happened to this method ?
Any reason you removed this functionality ?

@amanmahajan7
Copy link
Contributor

Cell range selection was quite buggy so we have removed it from canary for now but we have plans to add it back in the near future. However at this point this feature has not been prioritized. We are happy to accept a PR. Thank you all for you patience

@jmjuanico
Copy link

i think there is this PR does this solve the bug? not sure what other bugs there is but this one is a blocker. #1416

@nstepien
Copy link
Contributor

Closing as duplicate of #2260

@babakansari
Copy link

Cell range selection was quite buggy so we have removed it from canary for now but we have plans to add it back in the near future. However at this point this feature has not been prioritized. We are happy to accept a PR. Thank you all for you patience

Is this PR go to be merged?
#2865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants