From c0c5734ea9cacd4a6e419aebea81a872890981a0 Mon Sep 17 00:00:00 2001 From: FaragElsayed2 Date: Thu, 23 May 2024 20:07:29 +0300 Subject: [PATCH] Updating actions to be triggered on lvs changes, Updating esd and diodes derivations Signed-off-by: FaragElsayed2 --- .github/workflows/linting.yml | 6 ++++-- .github/workflows/lvs_regression.yml | 5 +++-- Makefile | 4 ++-- .../tech/lvs/rule_decks/diode_derivations.lvs | 10 +++++----- .../tech/lvs/rule_decks/esd_derivations.lvs | 4 ++-- .../unit/esd_devices/layout/diodevdd_2kv.gds | Bin 592602 -> 592666 bytes 6 files changed, 16 insertions(+), 13 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 64a278f2..3e630b82 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -15,10 +15,12 @@ # SPDX-License-Identifier: Apache-2.0 #========================================================================== -name: code linting +name: Python Code Linting + on: pull_request: - # push: + paths: + - 'ihp-sg13g2/libs.tech/klayout/tech/lvs/**' workflow_dispatch: jobs: diff --git a/.github/workflows/lvs_regression.yml b/.github/workflows/lvs_regression.yml index 5a8f9a17..100026f9 100644 --- a/.github/workflows/lvs_regression.yml +++ b/.github/workflows/lvs_regression.yml @@ -15,7 +15,7 @@ # SPDX-License-Identifier: Apache-2.0 #========================================================================== -name: LVS regression testing +name: LVS Regression Testing # Prevent keeping resources busy when a branch/PR is updated # https://docs.github.com/en/actions/using-jobs/using-concurrency @@ -24,8 +24,9 @@ concurrency: cancel-in-progress: true on: - # push: pull_request: + paths: + - 'ihp-sg13g2/libs.tech/klayout/tech/lvs/**' workflow_dispatch: jobs: diff --git a/Makefile b/Makefile index 24806360..bb18cbf7 100644 --- a/Makefile +++ b/Makefile @@ -43,8 +43,8 @@ env: $(TOP_DIR)/actions_venv # Lint python code lint_python: env - @echo "Running python linting for Klayout-tech directory" - @. $(VENV_RUN_COMMAND); flake8 ihp-sg13g2/libs.tech/klayout/tech/ + @echo "Running python linting for Klayout-LVS scripts" + @. $(VENV_RUN_COMMAND); flake8 ihp-sg13g2/libs.tech/klayout/tech/lvs #================================= # ----- test-LVS_regression ------ diff --git a/ihp-sg13g2/libs.tech/klayout/tech/lvs/rule_decks/diode_derivations.lvs b/ihp-sg13g2/libs.tech/klayout/tech/lvs/rule_decks/diode_derivations.lvs index e96cefa0..3e35fde3 100644 --- a/ihp-sg13g2/libs.tech/klayout/tech/lvs/rule_decks/diode_derivations.lvs +++ b/ihp-sg13g2/libs.tech/klayout/tech/lvs/rule_decks/diode_derivations.lvs @@ -23,11 +23,11 @@ logger.info('Starting DIODE DERIVATIONS') -diode_exclude = gatpoly.join(nsd_drw) - .join(trans_drw).join(emwind_drw).join(emwihv_drw) - .join(polyres_drw).join(extblock_drw).join(res_drw) - .join(activ_mask).join(recog_esd).join(ind_drw) - .join(ind_pin).join(substrate_drw) +diode_exclude = gatpoly.join(nsd_drw).join(trans_drw) + .join(emwind_drw).join(emwihv_drw).join(polyres_drw) + .join(extblock_drw).join(res_drw).join(activ_mask) + .join(recog_esd).join(ind_drw).join(ind_pin) + .join(substrate_drw) antenna_d_exc = pwell_block.join(salblock_drw) .join(nsd_block).join(diode_exclude) diff --git a/ihp-sg13g2/libs.tech/klayout/tech/lvs/rule_decks/esd_derivations.lvs b/ihp-sg13g2/libs.tech/klayout/tech/lvs/rule_decks/esd_derivations.lvs index c9b815a7..bd78b0ff 100644 --- a/ihp-sg13g2/libs.tech/klayout/tech/lvs/rule_decks/esd_derivations.lvs +++ b/ihp-sg13g2/libs.tech/klayout/tech/lvs/rule_decks/esd_derivations.lvs @@ -26,8 +26,8 @@ logger.info('Starting ESD DERIVATIONS') # General esd_exclude = nsd_block.join(nsd_drw).join(trans_drw) .join(emwind_drw).join(emwihv_drw).join(polyres_drw) - .join(extblock_drw).join(res_drw).join(recog_diode) - .join(substrate_drw).join(ind_drw).join(ind_pin) + .join(extblock_drw).join(res_drw).join(substrate_drw) + .join(ind_drw).join(ind_pin) esd_exc_d = gatpoly.join(thickgateox_drw).join(salblock_drw) .join(esd_exclude) diff --git a/ihp-sg13g2/libs.tech/klayout/tech/lvs/testing/testcases/unit/esd_devices/layout/diodevdd_2kv.gds b/ihp-sg13g2/libs.tech/klayout/tech/lvs/testing/testcases/unit/esd_devices/layout/diodevdd_2kv.gds index be80b19ec851c9e26f60d54371a5fd59cba8a4ae..47ab6a37cd3af0a4e5979636d3d9862247623f5a 100644 GIT binary patch delta 124 zcmcaLRb|#R6(t5X1}3Hm1{p>s_7@DS4B`wz4EzjS$n1$q%A!~$8lzgH7+a&5TBDd- zqgYy_SX-mmTBF!oqd2xkaaM8haWF8j@iH+aGqCY7G00DU^_|0rjh%skg@pkC8X*;Y delta 104 zcmbO=P36{96(t5X1}3Hm1{p>s_7@B+3_=Xt415f#$n1$q%A!~$8lzgH7+a&5TBDd- fqgYy_SX-mmTBF!oqd2xkaaM7$u`@8RurL4sk?;~b