Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Vertically center number in selection circle (fixes #198) #200

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix: Vertically center number in selection circle (fixes #198) #200

merged 1 commit into from
Mar 11, 2024

Conversation

swashbuck
Copy link
Contributor

Fix #198

Fix

  • Vertically centers the number in the selection circle

Testing

Set the @body-size variable to 1.5rem. Compare with the default value of 1rem. The number should be centered in both cases.

@swashbuck swashbuck added the bug label Mar 7, 2024
@swashbuck swashbuck self-assigned this Mar 7, 2024
guywillis
guywillis approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 11, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit 4b35712 into master Mar 11, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
@semantic-release-bot
Chore(release): 4.5.1 [skip ci]
1b5e1b1 
## [4.5.1](v4.5.0...v4.5.1) (2024-03-11)

### Fix

* Vertically center number in selection circle (fixes #200) ([4b35712](4b35712)), closes [#200](#200)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#199) ([d585fc2](d585fc2)), closes [#199](#199)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number selection alignment
4 participants
@swashbuck @guywillis @cahirodoherty-learningpool @joe-allen-89