Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove unnecessary properties for tile/grid layout (fixes #314) #323

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Oct 3, 2024

Fix #314

Fix

  • Ensures that the _graphic property on the main component is not required when using the tile / grid layout.
  • Update example.json to remove unnecessary properties for the tile / grid layout: _top, _left, and _imageAlignment for each item.
  • Update example.json to add clarity between the different layout types and to add more realistic image file names.
  • Update README.md to add notes about tile/grid properties.

@swashbuck swashbuck self-assigned this Oct 3, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Reviewing
Development

Successfully merging this pull request may close these issues.

Framework: Required fields for tile layout
3 participants