Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Add has-numbered-pins class when using numbered pins (fix #320) #321

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Update: Add has-numbered-pins class when using numbered pins (fix #320) #321

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfa9d46
Add br tags to readme
swashbuck Sep 27, 2024
d6bc5aa
Fix typo in PR template
swashbuck Sep 27, 2024
eccac1e
Add has-numbered-pins when using numbered pins
swashbuck Sep 27, 2024
bce4f45
Move numbered pin class to pin buttons
swashbuck Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* A sentence describing each fix

### Update
* A sentence describing each udpate
* A sentence describing each update

### New
* A sentence describing each new feature
Expand Down
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ These labels are not visible elements. They are utilized by assistive technology

----------------------------
<a href="https://community.adaptlearning.org/" target="_blank"><img src="https://github.com/adaptlearning/documentation/blob/master/04_wiki_assets/plug-ins/images/adapt-logo-mrgn-lft.jpg" alt="adapt learning logo" align="right"></a>
**Author / maintainer:** Adapt Core Team with [contributors](https://github.com/adaptlearning/adapt-contrib-hotgraphic/graphs/contributors)
**Accessibility support:** WAI AA
**RTL support:** Yes
**Cross-platform coverage:** Chrome, Chrome for Android, Firefox (ESR + latest version), Edge, Safari 14 for macOS/iOS/iPadOS, Opera
**Author / maintainer:** Adapt Core Team with [contributors](https://github.com/adaptlearning/adapt-contrib-hotgraphic/graphs/contributors)<br>
**Accessibility support:** WAI AA<br>
**RTL support:** Yes<br>
**Cross-platform coverage:** Chrome, Chrome for Android, Firefox (ESR + latest version), Edge, Safari 14 for macOS/iOS/iPadOS, Opera<br>
2 changes: 2 additions & 0 deletions templates/hotgraphic.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export default function Hotgraphic(props) {

const {
_graphic,
_useNumberedPins,
_useGraphicsAsPins
} = props;

Expand All @@ -16,6 +17,7 @@ export default function Hotgraphic(props) {
<div className={classes([
'component__widget hotgraphic__widget',
_useGraphicsAsPins ? 'is-tile' : 'is-pin',
_useNumberedPins && 'has-numbered-pins',
_graphic.attribution && 'has-attribution'
])}>

Expand Down
Loading