Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to call install command multiple times #143

Open
tomgreenfield opened this issue Apr 27, 2021 · 0 comments
Open

Unable to call install command multiple times #143

tomgreenfield opened this issue Apr 27, 2021 · 0 comments

Comments

@tomgreenfield
Copy link
Contributor

Error

Copied from adapt-security/adapt-authoring#280:

We're currently not able to run the CLI in parallel, as errors are thrown (think this could be caused by some kind of global scope).

An array of promises is being returned for each invocation of the install command when run in parallel, instead of a single resolved/rejected promise.

To reproduce

In framework directory:

  1. Add installParallel.js:

    (async function() {
      const cli = require('adapt-cli').api.commands;
      const plugins = [
        'adapt-contrib-accordion',
        'adapt-contrib-slider',
        'adapt-contrib-vanilla'
      ];
      const results = await Promise.allSettled(plugins.map(plugin => cli.install(plugin)));
      results.forEach((result, i) => console.log(plugins[i], result.value || result.reason));
    }());
  2. Run:

    npm install adapt-cli
    node installParallel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant