Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Transformers to v4.47.x #776

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Upgrade Transformers to v4.47.x #776

merged 6 commits into from
Jan 8, 2025

Conversation

calpt
Copy link
Member

@calpt calpt commented Jan 4, 2025

No description provided.

@calpt calpt added the sync label Jan 4, 2025
@lenglaender lenglaender self-assigned this Jan 7, 2025
@lenglaender
Copy link
Member

lenglaender commented Jan 7, 2025 •
edited
Loading

Currently, tests/models/test_electra.py::ElectraModelTest::test_inputs_embeds_matches_input_ids_with_generate is failing for all PRs (like #763, #777, #774 or #759). This is a Hugging Face test that no longer exists in version 4.47. Therefore, it would be good if we could merge this sync PR as quickly as possible so that the tests pass again for all other PRs. I've quickly fixed all the remaining bugs except for one last thing with DebertaV2 so once this is fixed and reviewed, we can hopefully merge it and then all other PRs can be merged for the coming release.

@lenglaender lenglaender marked this pull request as ready for review January 7, 2025 14:09
TimoImhof
TimoImhof approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@TimoImhof TimoImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@TimoImhof TimoImhof merged commit 7c2357f into adapter-hub:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoImhof TimoImhof TimoImhof approved these changes

Assignees

@lenglaender lenglaender

Labels
sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calpt @lenglaender @TimoImhof