Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace aiffSampleRateTable unordered_map to ieee80 converter #85

Closed
wants to merge 1 commit into from

Conversation

alxarsenault
Copy link
Contributor

I found a way to remove that enoying global aiffSampleRateTable unordered_map.
This is highly based on this code https://gist.github.com/Angeldude/e5291417f2eb00d81f7c.

@adamstark
Copy link
Owner

I've wanted to get rid of that table for ages - nice! My only question is that I don't know the licence of the gist you based it on... we should add an acknowledgement to the library at least... but maybe there are other requirements in a licence somewhere?

@alxarsenault
Copy link
Contributor Author

I don't really have an answer for that. An acknowledgement for sure yes. I feel like the code has been modified enough for it not to be subject to the license.

@alxarsenault
Copy link
Contributor Author

alxarsenault commented Nov 8, 2023

Seems to have been taken from here.
https://github.com/bzgeb/portsf

/* Copyright (c) 1991-1992 above authors

Permission is hereby granted, free of charge, to any person
obtaining a copy of this software and associated documentation
files (the "Software"), to deal in the Software without
restriction, including without limitation the rights to use,
copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the
Software is furnished to do so, subject to the following
conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.
*/

@alxarsenault
Copy link
Contributor Author

I actually happen to own that book and I think the code in on the cd that came with it.
IMG_0311

@adamstark
Copy link
Owner

Hey, I finally got around to looking at this, sorry it took me so long. I wasn't very keen on using some code already out there (partly for attribution issues but also I found it quite hard to understand and I like to have a grasp of what's going on). So I ended up diving into the topic and have written my own encode and decode functions for the AIFF sample rates now. It's on the develop branch now. Thank you for inspiring me to take a look at this! I'd add your names to the contributors list in the README, but you're already there :)

@adamstark adamstark closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants