Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AudioFile.h in cmake library interface #82

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

alxarsenault
Copy link
Contributor

I added the AudioFile.h to the library, and cleaned up a couple other stuff.

@adamstark
Copy link
Owner

Thanks for this! I'm really bad at cmake haha, so forgive me if my questions are stupid. Does the moving of the D_USE_MATH_DEFINESflag to the examples and tests CMakeLists.txt files mean that someone on Windows would need to have this as a requirement in their project and would get a build failure otherwise?

@adamstark adamstark changed the base branch from master to develop November 7, 2023 16:33
@alxarsenault
Copy link
Contributor Author

alxarsenault commented Nov 7, 2023

Before, USE_MATH_DEFINES was added in the main project, so somebody including the project would have a USE_MATH_DEFINES automatically added to their project when including the library. Now it is just added in the examples and tests project so it doesn't affect the library. Make sense ?

@alxarsenault alxarsenault deleted the cmake-update branch November 9, 2023 00:48
@alxarsenault alxarsenault restored the cmake-update branch November 9, 2023 00:51
@alxarsenault alxarsenault reopened this Nov 9, 2023
@alxarsenault
Copy link
Contributor Author

Sorry, I thought you merged it into develop but finally it was just a 'change base branch from master to develop'

@adamstark adamstark merged commit be8d0e0 into adamstark:develop Nov 18, 2024
6 checks passed
@adamstark
Copy link
Owner

Sorry that it took me so long to review all this properly - and thank you for the contribution. I've just merged it in now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants