Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings for UniProt (which cannot be specified in settings.json) #712

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Settings for UniProt (which cannot be specified in settings.json) #712

wants to merge 1 commit into from

Conversation

hannahbast
Copy link
Member

  1. Externalize literals longer than 128 bytes (default is 1024 bytes).

  2. Externalize all objects of the predicates
    http://www.w3.org/1999/02/22-rdf-syntax-ns#value and
    http://purl.uniprot.org/core/md5Checksum .

@hannahbast hannahbast mentioned this pull request Jul 29, 2022
Closed
@hannahbast
Copy link
Member Author

Rebased to current master. This became necessary because the code for tripleToInternalRepresentation moved from src/index/Index.cpp to src/index/IndexImpl and also changed slightly.

@codecov
Copy link

codecov bot commented Feb 22, 2023 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (95fc20b) 85.82% compared to head (6068bf7) 85.79%.

Files Patch % Lines
src/index/IndexImpl.cpp 37.50% 2 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   85.82%   85.79%   -0.04%     
==========================================
  Files         308      308              
  Lines       29266    29273       +7     
  Branches     3430     3434       +4     
==========================================
- Hits        25117    25114       -3     
- Misses       2787     2789       +2     
- Partials     1362     1370       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Settings for UniProt (which cannot be specified in settings.json)
6068bf7 
1. Externalize literals longer than 128 bytes (default is 1M bytes).

2. Externalize all objects of the predicates
<http://www.w3.org/1999/02/22-rdf-syntax-ns#value> and
<http://purl.uniprot.org/core/md5Checksum> .
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hannahbast