Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement comparison of two geo points #1801

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Implement comparison of two geo points #1801

merged 3 commits into from
Feb 19, 2025

Conversation

hannahbast
Copy link
Member

@hannahbast hannahbast commented Feb 12, 2025

This was not implemented so far and crashed the server when two geo points were compared.
Also add static_asserts that will make such crashes less likely when datatypes are added in the future. Fixes #1791

This was not implemented so far and crased the server when two geo points were compared.
Fixes #1791
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.10%. Comparing base (1213437) to head (81a89bd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/global/ValueIdComparators.h 16.66% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1801      +/-   ##
==========================================
- Coverage   90.14%   90.10%   -0.05%     
==========================================
  Files         399      399              
  Lines       38213    38220       +7     
  Branches     4281     4283       +2     
==========================================
- Hits        34448    34439       -9     
- Misses       2473     2485      +12     
- Partials     1292     1296       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sparql-conformance
Copy link

@joka921 joka921 merged commit 4fa1fea into master Feb 19, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query crashes server via /qlever/src/global/ValueIdComparators.h:519
2 participants