Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Store HTTP Protocol (GET, POST) back end #1668
Graph Store HTTP Protocol (GET, POST) back end #1668
Changes from 23 commits
0e1394a
f840757
a1a96e6
a7cb7ba
e863950
364d425
6c9cc65
eaa76d4
8deab38
63aa1da
ff6d023
a2a95c9
2fd9677
c700734
c2ec8cf
5bafc3d
4dd0ab7
750dd6f
ec8f076
d45b2da
ff36dfd
8868668
ec03ba1
ff86b11
22be268
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some thoughts for you to comment on:
RdfStringViewParser
, but we currently don't.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that something that will be beneficial for all operations that have some payload. One thing that is also excluded from this initial implementation is the processing of
multipart/form-data
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RdfStringParser
afaik always copies the inpuit string. We could and I'd expect it to be easier thanRdfStreamParser
. But this has a low priority atm.RdfStreamParser
for files, I'd doubt the first sentence. Yes processing the body of HTTP requests chunked would be nice for all operations where the body could get large (Graph Store PUT, POST, Update DELETE and INSERT DATA). But again comparatively low priority.Check warning on line 81 in src/engine/GraphStoreProtocol.h
Codecov / codecov/patch
src/engine/GraphStoreProtocol.h#L80-L81
Check warning on line 352 in src/engine/Server.cpp
Codecov / codecov/patch
src/engine/Server.cpp#L351-L352
Check warning on line 997 in src/engine/Server.cpp
Codecov / codecov/patch
src/engine/Server.cpp#L997