Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Store HTTP Protocol (GET, POST) back end #1668

Merged
merged 25 commits into from
Jan 22, 2025

Conversation

Qup42
Copy link
Member

@Qup42 Qup42 commented Dec 8, 2024

Implement a function transformGraphStoreProtocol that does the back end of transforming a SPARQL Graph Store HTTP Protocol request to it's equivalent SPARQL Query or Update. The integration will be a separate step.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.90%. Comparing base (a97905e) to head (22be268).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/Server.cpp 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
+ Coverage   89.86%   89.90%   +0.04%     
==========================================
  Files         389      392       +3     
  Lines       37189    37448     +259     
  Branches     4196     4220      +24     
==========================================
+ Hits        33419    33668     +249     
- Misses       2473     2482       +9     
- Partials     1297     1298       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qup42 Qup42 marked this pull request as ready for review December 16, 2024 11:29
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first round of reviews, this is already looking very promising.

src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/parser/TripleComponent.h Outdated Show resolved Hide resolved
test/util/HttpRequestHelpers.h Outdated Show resolved Hide resolved
test/GraphStoreProtocolTest.cpp Outdated Show resolved Hide resolved
test/GraphStoreProtocolTest.cpp Outdated Show resolved Hide resolved
test/GraphStoreProtocolTest.cpp Outdated Show resolved Hide resolved
@Qup42 Qup42 requested a review from joka921 January 10, 2025 15:33
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had forgotten to send the review...

src/engine/GraphStoreProtocol.cpp Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.cpp Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.cpp Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.cpp Outdated Show resolved Hide resolved
test/GraphStoreProtocolTest.cpp Outdated Show resolved Hide resolved
test/util/HttpRequestHelpers.h Outdated Show resolved Hide resolved
@sparql-conformance
Copy link

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, that looks rather
clear now.

@joka921 joka921 merged commit d7ec9be into ad-freiburg:master Jan 22, 2025
24 checks passed
@Qup42 Qup42 deleted the processGraphStoreRequest branch January 23, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants