-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Store HTTP Protocol (GET, POST) back end #1668
Conversation
# Conflicts: # test/ServerTest.cpp
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1668 +/- ##
==========================================
+ Coverage 89.86% 89.90% +0.04%
==========================================
Files 389 392 +3
Lines 37189 37448 +259
Branches 4196 4220 +24
==========================================
+ Hits 33419 33668 +249
- Misses 2473 2482 +9
- Partials 1297 1298 +1 ☔ View full report in Codecov by Sentry. |
# Conflicts: # src/engine/CMakeLists.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first round of reviews, this is already looking very promising.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had forgotten to send the review...
Conformance check passed ✅No test result changes. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, that looks rather
clear now.
Implement a function
transformGraphStoreProtocol
that does the back end of transforming a SPARQL Graph Store HTTP Protocol request to it's equivalent SPARQL Query or Update. The integration will be a separate step.