Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the race conditions in Boost ASIO. #1266

Closed
wants to merge 13 commits into from

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Feb 6, 2024

No description provided.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (ea9d258) 87.50% compared to head (677bd10) 87.49%.
Report is 6 commits behind head on master.

❗ Current head 677bd10 differs from pull request most recent head e16ddfa. Consider uploading reports for the commit e16ddfa to get more accurate results

Files Patch % Lines
src/util/AsioHelpers.h 91.24% 7 Missing and 5 partials ⚠️
src/util/http/websocket/QueryHub.cpp 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
- Coverage   87.50%   87.49%   -0.01%     
==========================================
  Files         308      308              
  Lines       27922    28022     +100     
  Branches     3126     3131       +5     
==========================================
+ Hits        24432    24518      +86     
- Misses       2350     2359       +9     
- Partials     1140     1145       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@joka921 joka921 closed this Feb 28, 2024
@joka921 joka921 deleted the race-condition-asio branch February 28, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant