Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor timer class to use more type safe types #1139

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Nov 9, 2023

  • Timer::msecs now returns std::chrono::milliseconds instead of size_t.
  • Add an overload to RuntimeInfo::addDetail that takes std::chrono::milliseconds directly.
  • Address some code smells and one TODO<C++20> in the code that was touched anyway.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (cf2d0b1) 81.19% compared to head (14f6ec0) 81.27%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
+ Coverage   81.19%   81.27%   +0.07%     
==========================================
  Files         299      301       +2     
  Lines       27746    27870     +124     
  Branches     3381     3387       +6     
==========================================
+ Hits        22529    22650     +121     
+ Misses       3830     3828       -2     
- Partials     1387     1392       +5     
Files Coverage Δ
src/engine/ExportQueryExecutionTrees.cpp 91.32% <100.00%> (-0.02%) ⬇️
src/engine/Operation.cpp 83.21% <100.00%> (-0.13%) ⬇️
src/engine/RuntimeInformation.cpp 100.00% <100.00%> (ø)
src/engine/RuntimeInformation.h 100.00% <ø> (ø)
src/index/CompressedRelation.cpp 97.99% <100.00%> (-0.02%) ⬇️
src/index/ConstantsIndexBuilding.h 100.00% <100.00%> (ø)
src/index/IndexBuilderTypes.h 95.34% <100.00%> (+0.90%) ⬆️
src/util/Algorithm.h 98.52% <100.00%> (+0.16%) ⬆️
src/util/BackgroundStxxlSorter.h 95.55% <ø> (ø)
src/util/Serializer/ByteBufferSerializer.h 84.21% <100.00%> (+6.43%) ⬆️
... and 10 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, only some small suggestions remain.

src/engine/Sort.cpp Outdated Show resolved Hide resolved
src/util/TaskQueue.h Outdated Show resolved Hide resolved
src/util/Timer.h Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joka921 joka921 merged commit fb35c6b into ad-freiburg:master Nov 10, 2023
18 checks passed
@RobinTF RobinTF deleted the timer-refactor branch November 11, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants