-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor timer class to use more type safe types #1139
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
+ Coverage 81.19% 81.27% +0.07%
==========================================
Files 299 301 +2
Lines 27746 27870 +124
Branches 3381 3387 +6
==========================================
+ Hits 22529 22650 +121
+ Misses 3830 3828 -2
- Partials 1387 1392 +5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, only some small suggestions remain.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Timer::msecs
now returnsstd::chrono::milliseconds
instead ofsize_t
.RuntimeInfo::addDetail
that takesstd::chrono::milliseconds
directly.TODO<C++20>
in the code that was touched anyway.