Add more possible types for the entries of Benchmark::ResultTable
#1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he handeling of possible types for a ResultTable entry.
…sultTable can now be bools.
…sultTable can now be signed and unsigned integers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1134 +/- ##
=======================================
Coverage 81.19% 81.19%
=======================================
Files 299 299
Lines 27746 27746
Branches 3381 3381
=======================================
Hits 22529 22529
Misses 3830 3830
Partials 1387 1387 ☔ View full report in Codecov by Sentry. |
joka921
requested changes
Nov 8, 2023
…calls of AD_CONTRACT_CHECK(false) with AD_FAIL.()
…iting lambda. It's a macro benchmark, such short times imply a higher time measurement precision, than is the case.
joka921
requested changes
Nov 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
joka921
approved these changes
Nov 9, 2023
joka921
changed the title
ResultTableBenchmark::ResultTable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a table as the result of a benchmark run, each entry of the table now can be any of the following:
int, float, string, bool.