From 3dc846a513d5ec8ddbc7f4718ea561dd93242dd2 Mon Sep 17 00:00:00 2001 From: Hannah Bast Date: Sun, 17 Nov 2024 20:32:44 +0100 Subject: [PATCH] Improve comment and error message --- src/engine/TransitivePathImpl.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/engine/TransitivePathImpl.h b/src/engine/TransitivePathImpl.h index 9a35a1bc37..849df70f78 100644 --- a/src/engine/TransitivePathImpl.h +++ b/src/engine/TransitivePathImpl.h @@ -314,16 +314,16 @@ class TransitivePathImpl : public TransitivePathBase { // Bound -> var|id std::span startNodes = startSideResult->idTable().getColumn( startSide.treeAndCol_.value().second); - // Non-empty local vocab for map is not supported yet. + // TODO: The current code does not work if the local vocab of the start + // side result is not empty. if (!startSideResult->localVocab().empty()) { AD_THROW( - "Local vocab in `startSideResult` of `TransitivePath` is not " - "supported, please report this issue"); + "The current code for a `TransitivePath` operation does not work " + "if the result is materialized and the local vocab is not empty; " + "please report this issue"); } co_yield TableColumnWithVocab{ &startSideResult->idTable(), startNodes, {}}; - // co_yield TableColumnWithVocab{&startSideResult->idTable(), startNodes, - // startSideResult->getCopyOfLocalVocab()}; } else { for (auto& [idTable, localVocab] : startSideResult->idTables()) { // Bound -> var|id