Skip to content

Commit

Permalink
Improve comment and error message
Browse files Browse the repository at this point in the history
  • Loading branch information
Hannah Bast committed Nov 17, 2024
1 parent 85cd239 commit 3dc846a
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/engine/TransitivePathImpl.h
Original file line number Diff line number Diff line change
Expand Up @@ -314,16 +314,16 @@ class TransitivePathImpl : public TransitivePathBase {
// Bound -> var|id
std::span<const Id> startNodes = startSideResult->idTable().getColumn(
startSide.treeAndCol_.value().second);
// Non-empty local vocab for map is not supported yet.
// TODO: The current code does not work if the local vocab of the start
// side result is not empty.
if (!startSideResult->localVocab().empty()) {
AD_THROW(
"Local vocab in `startSideResult` of `TransitivePath` is not "
"supported, please report this issue");
"The current code for a `TransitivePath` operation does not work "
"if the result is materialized and the local vocab is not empty; "
"please report this issue");
}

Check warning on line 324 in src/engine/TransitivePathImpl.h

View check run for this annotation

Codecov / codecov/patch

src/engine/TransitivePathImpl.h#L320-L324

Added lines #L320 - L324 were not covered by tests
co_yield TableColumnWithVocab{
&startSideResult->idTable(), startNodes, {}};
// co_yield TableColumnWithVocab{&startSideResult->idTable(), startNodes,
// startSideResult->getCopyOfLocalVocab()};
} else {
for (auto& [idTable, localVocab] : startSideResult->idTables()) {
// Bound -> var|id
Expand Down

0 comments on commit 3dc846a

Please sign in to comment.