Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added different enhancements #86

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Added different enhancements #86

merged 3 commits into from
Jan 1, 2025

Conversation

acuciureanu
Copy link
Owner

This pull request introduces significant changes to the project, including the addition of a new BrowserPoolManager class, updates to the testing framework, and documentation improvements. The most important changes are outlined below:

New Features:

  • services/browser.service.js: Added a new BrowserPoolManager class to manage Puppeteer browser instances with a pool. This class includes methods for acquiring and releasing browsers, creating optimized pages, and retrieving pool metrics.

Testing Enhancements:

  • services/__tests__/browser.service.test.js: Added comprehensive tests for the BrowserPoolManager class, including tests for browser pool configuration, browser acquisition and release, and optimized page creation.

Configuration Updates:

  • package.json: Updated the scripts section to include Jest testing commands (test, test:coverage, test:watch). Added jest and generic-pool to dependencies. Also added Jest configuration for the test environment. [1] [2] [3]

Documentation Improvements:

  • README.md: Updated the "Buy Me A Coffee" link to use Markdown syntax and specified the language for the code block in the installation section. [1] [2]

Minor Changes:

  • LICENSE.md: Added a missing hash symbol to the MIT License title for proper Markdown formatting.

@acuciureanu acuciureanu merged commit 3fa7205 into main Jan 1, 2025
2 checks passed
Copy link

github-actions bot commented Jan 1, 2025

🎉 This PR is included in version 1.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant