1006.2 Partial #1044
1006.2 Partial #1044
Conversation
Partial commit to share with Andrew while we debug 404 error in org store addSocialLink method
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Restored files from PR 1037. CardConnect.vue PopupNewField.vue organization.ts types/social-links-payload.ts
|
A bunch of changes have gone through, @mattburnett-repo, so I'd suggest rebasing this at this point :) We can chat about it next week/weekend! |
|
We should be able to work on this once #1079 is merged in, @mattburnett-repo :) I have a bunch of minor frontend changes that have yet to be committed, but then we should be relatively table as far as models and access methods are concerned 😊 |
|
#1079 is merged and I took care of the conflicts, @mattburnett-repo :) Let me know if there was some new reason that we need those Let me know as well when a call to look into this would work :) |
|
Thanks so much @andrewtavis ! If I remember correctly, I typed the URL things as 'string' to make some TypeScript warnings go away in my IDE. I'll do a fresh pull / merge during daytime hours and have a look at the new code. |
|
@mattburnett-repo: Checking in for the call here as you were active on here just a bit ago :) In the sync :) |
|
|
UI can create a payload and call the backend with it.
|
Still aren't quite there on this, @mattburnett-repo, but this at least integrates your and my work on it :) I'll be able to take a bit better of a look at this tomorrow. |
|
Really appreciate it, @andrewtavis !!! Thanks! |
|
One thing is that the modal is still closing regardless of the fact that those requests are failing when we try to update them. Would be great if the modal stayed open if the request didn't go through. Obviously we'll see that it's not changed, but it not reacting like it worked would be good :) |
|
57ed327 brings in the Yarn 4 setup here, @mattburnett-repo :) You should be good to git pull directly. |
Frontend sends social link data in a single API request. Backend handles social link data as needed.
There was a problem hiding this comment.
Thanks so much for the persistence to bring this in, @mattburnett-repo! So happy to finally have this feature to completion after its many many iterations 😊 Great to have you also interacting more with the backend 😉
|
You're very welcome, @andrewtavis ! It's been good to get more up to speed with how the backend works, in order to be more helpful with future backend-related work. Thanks for the opportunity! |
Contributor checklist
Description
Related issue