Skip to content

Commit

Permalink
Merge branch 'master' of ssh://github.com/prevwong/craft.js
Browse files Browse the repository at this point in the history
  • Loading branch information
prevwong committed Jan 17, 2020
2 parents 06cd435 + cf5392b commit 8a387f5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
9 changes: 0 additions & 9 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,6 @@ assignees: ''

---

**Is your feature request related to the core ?**

Remember that Craft.js is an abstraction; implementation-related features are not part of the core.

"Implement API to handle drag preview", "Add editor action to copy elements", "Show drag preview when dragging elements" are examples of feature requests that are related to the core.

"Implement a file uploader", "Add a gallery component", "Add a layers panel", "Create tooltip component" are examples of feature requests that are **not** related to the core. We could still consider working on some of them as separate packages (eg: [@craftjs/layers](https://github.com/prevwong/craft.js/tree/master/packages/layers)). However, please understand that these will not be top priority at the moment.


**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Expand Down
2 changes: 1 addition & 1 deletion packages/docs/docs/api/NodeHelpers.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {useEditor} from "@craftjs/core";

const TextComponent = () => {
const { id } = useNode();
const { query: {is} } = useEditor();
const { query: {node} } = useEditor();
const isRoot = node(id).Root(),
isDraggable = node(id).Draggable();
...
Expand Down

0 comments on commit 8a387f5

Please sign in to comment.