Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 #20

Merged
merged 22 commits into from
Jan 22, 2024
Merged

V4 #20

merged 22 commits into from
Jan 22, 2024

Conversation

zozlak
Copy link
Member

@zozlak zozlak commented Aug 3, 2022

Backward incompatible changes

  • Drop acdh:hasLocationPath as we don't use it for quite some time already. Triples with that property (e.g. 55k on apollo) can be just removed.

New properties

  • acdh:hasOrder
    • rationale: It already popped out a few times that arche-based project services would like to be able to order resources within a collection in a deterministic way and none of existing properties really fits this purpose. This would also allow to extend the Drupal GUI-embedded viewers with controls allowing direct open of the next/previous resource in the collection or to reliably generate iiif manifests for collections.
    • TODO
      • review labels and add German ones
      • decide on acdh:ordering value
  • Non-linked counterparts to acdh:hasCoverage (acdh:hasNonLinkedCoverage), acdh:hasContributor (acdh:hasNonLinkedContributor) and their subproperties (acdh:hasActor - acdh:hasNonLinkedActor, acdh:hasSpatialCoverage - acdh:hasNonLinkedSpatialCoverage, acdh:hasCreator - acdh:hasNonLinkedCreator, acdh:hasDigitisingAgent - acdh:hasNonLinkedDigitisingAgent, acdh:hasEditor - acdh:hasNonLinkedEditor, acdh:hasFunder - acdh:hasNonLinkedFunder, acdh:hasPrincipalInvestigator - acdh:hasNonLinkedPrincipalInvestigator)
    • rationale: see here
    • remarks:
      • Non-linked counterparts were created only for non-compulsory properties as for compulsory ones (achd:hasContact, acdh:hasDepositor, acdh:hasHosting, acdh:hasLicensor, acdh:hasMetadataCreator, acdh:hasOwner, acdh:hasRightsHolder) we won't be able to express the cardinality restriction. We can also look at it in a way that compulsory properties so important that we require them to be LOD.
      • Non-linked counterparts don't have acdh:recommendedClass annotations but if we think they should, we can add them.
      • Non-linked counterparts don't have owl:inverseOf annotations because they are datatype properties.
    • TODO
      • decide on naming. I've chosen acdh:hasNonLinked{originalProperty} because we already had acdh:hasNonLinkedIdentifier but I'm not personally attached
      • review labels and add German ones
      • decide on acdh:ordering values

zozlak added 4 commits August 3, 2022 16:05
Non-linked variants were created only for optional and recommended
properties as for required ones we would be unable to properly express
the cardinality requirement. We can also look at it in a way that if a
property is required, it's so imporant we want it to be LOD and don't
allow non-linked data.
@bellerophons-pegasus
Copy link
Member

I do agree with introducing acdh:hasOrder and dropping acdh:hasLocationPath

The introduction of non-linked counterparts to acdh:hasCoverage (acdh:hasNonLinkedCoverage), acdh:hasContributor(acdh:hasNonLinkedContributor) and their subproperties raises many red flags and from the notes I can't really see why we really need them...

@bellerophons-pegasus bellerophons-pegasus self-requested a review August 8, 2022 21:40
@bellerophons-pegasus
Copy link
Member

Could you maybe please remind me on how the folder structure of downloaded collections is now determined without acdh:hasLocationPath?

Copy link
Member

@bellerophons-pegasus bellerophons-pegasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please think again about introducing the new non-linked properties

@zozlak
Copy link
Member Author

zozlak commented Aug 9, 2022

Could you maybe please remind me on how the folder structure of downloaded collections is now determined without acdh:hasLocationPath?

It's based on acdh:isPartOf now (see #13481)

@bellerophons-pegasus
Copy link
Member

@zozlak and I talked and came to this conclusion:

Introduce the following properties:

  • acdh:hasOrder - all fine (we didn't talk about it, but for the sake of completeness is included in this list
  • acdh:hasNonLinkedActor

Why not the others as well? Because it seems that most messy named entities (Agents) are coming in via acdh:hasActor and also the other properties more often tend to denote living people (or more current organisations) where we can ask depositors to provide an ORCID or another identifier.

As for acdh:hasCoverage, especially acdh:hasSpatialCoverage: see Redmine #19100

Thus, remove acdh:hasNonLinkedCoverage, acdh:hasNonLinkedSpatialCoverage, acdh:hasNonLinkedContributor, acdh:hasNonLinkedCreator, acdh:hasNonLinkedDigitisingAgent, acdh:hasNonLinkedEditor, acdh:hasNonLinkedFunder, and acdh:hasNonLinkedPrincipalInvestigator

@bellerophons-pegasus
Copy link
Member

For acdh:hasNonLinkedActor please include

<rdfs:comment xml:lang="en">Any Person or Organisation (B) which the given Project, Collection or Resource (A) mentions or is about that has no identifier any of the authority files supported by the repository.</rdfs:comment>
<rdfs:comment xml:lang="de">Jede Person oder Organisation (B), die in der vorliegenden Ressource, der Sammlung oder dem Projekt (A) erwähnt wird oder mit der sie sich befasst und die keinen Identifikator in einer der vom Repositorium unterstützten  Normdateien hat.</rdfs:comment>
<skos:altLabel xml:lang="en">Has non-linked Actor</skos:altLabel>
<skos:altLabel xml:lang="de">Hat Akteur ohne Link</skos:altLabel>

For acdh:hasOrder please include

<acdh:ordering rdf:datatype="http://www.w3.org/2001/XMLSchema#integer">176</acdh:ordering>
<rdfs:comment xml:lang="en">Indicates the order of a Resource or Collection within a containing Collection.</rdfs:comment>
        <rdfs:comment xml:lang="de">Gibt die Reihenfolge einer Ressource oder Sammlung innerhalb einer Sammlung an.</rdfs:comment>
        <skos:altLabel xml:lang="de">Sortiernummer</skos:altLabel>
        <skos:altLabel xml:lang="en">Order number</skos:altLabel>

Also: should acdh:hasOrder have a default value when not provided? Or be filled with some kind of automation?

* drop acdh:hasNonLinkedCoverage, acdh:hasNonLinkedSpatialCoverage, acdh:hasNonLinkedContributor, acdh:hasNonLinkedCreator, acdh:hasNonLinkedDigitisingAgent, acdh:hasNonLinkedEditor, acdh:hasNonLinkedFunder, and acdh:hasNonLinkedPrincipalInvestigator
* fix acdh:ordering, rdf:comment and skos:altLabel for acdh:hasOrder and
  acdh:hasNonLinkedActor
@zozlak
Copy link
Member Author

zozlak commented Jan 8, 2024

@bellerophons-pegasus I have a doubt regarding the acdh:hasCustomIiifManifest name. As raised in https://redmine.acdh.oeaw.ac.at/issues/22279 it is very plausible we will need/want to mark all collections for which a IIIF manifest should be generated with a dedicated metadata property. For such a usage a hasCustomIiifManifest sounds a little strange and I would rather avoid having two separate properties for dealing with IIIF manifests (one for a specific and one for an automatically generated). For that reason I would opt for calling this property just an acdh:hasIiifManifest.

My second doubt is about the acdh:hasOrder. After thinking a little about it I'm not sure if it's better to introduce the acdh:hasOrder or maybe acdh:hasNext[Object]. I will write down my thoughts about it in the https://redmine.acdh.oeaw.ac.at/issues/22435 in a moment.

@bellerophons-pegasus bellerophons-pegasus removed the request for review from sstuhec January 10, 2024 11:22
acdh-schema.owl Outdated
@@ -212,14 +242,26 @@ Kardinalität von acdh:hasCategory für acdh:BinaryContent gändert zu 0-n, um m

<owl:AnnotationProperty rdf:about="https://vocabs.acdh.oeaw.ac.at/schema#defaultValue">
<rdfs:comment xml:lang="de">Gibt den Standardwert einer Eigenschaft an. Der Standardwert wird verwendet, wenn diese Eigenschaft in einer Klasse verwendet wird, aber kein Wert angegeben wurde.</rdfs:comment>
<rdfs:comment xml:lang="en">Indicates a default property value. The default value is assigned when a class matches property&apos;s domain but no property value has been provided.</rdfs:comment>
<rdfs:comment xml:lang="en">Indicates a default property value. The default value is assigned when a class matches property&amp;apos;s domain but no property value has been provided.</rdfs:comment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a small typo here, &amp;apos; should be corrected to &apos;

acdh-schema.owl Outdated
<rdfs:domain rdf:resource="https://vocabs.acdh.oeaw.ac.at/schema#BinaryContent"/>
<rdfs:range rdf:resource="http://www.w3.org/2001/XMLSchema#anyURI"/>
<rdfs:comment xml:lang="de">Gibt das IIIF-Manifest (B) an, das für die Darstellung der Ressource (A) verwendet werden soll. Der Wert ist entweder die URL des zu verwendenden IIIF-Manifests (externe URLs sind möglich, wir empfehlen jedoch Ressourcen aus dem Repositorium) oder, wenn das IIIF-Manifest automatisch auf der Grundlage der Metadaten der Ressource generiert werden soll, die URI des Dissemination-Services: https://id.acdh.oeaw.ac.at/dissemination/iiifmanifest.</rdfs:comment>
<rdfs:comment xml:lang="en">Indicates the IIIF manifest (B) to be used for the presentation of the Resource (A). The value is either an URL of the IIIF manifest to be used (we recommend it to be another Resource in the repository but it can also be external) or, if the IIIF manifest should be generated automatically based on the Resoure&apos;s metadata, the URI of the dissemination service: https://id.acdh.oeaw.ac.at/dissemination/iiifmanifest.</rdfs:comment>
Copy link
Contributor

@carlonim carlonim Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small typos:

  1. remove double white space between external) and or
  2. correct Resoure to Resource

Copy link
Contributor

@carlonim carlonim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems ok from a formal point of view. I just added some comments regarding small typos:

Copy link
Member

@bellerophons-pegasus bellerophons-pegasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll leave the version info as it is. Otherwise thank you for noting the typos.

@zozlak zozlak merged commit 3bcc445 into master Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants