Fix mutexes in sc_prim_channel #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfoodyburton
force-pushed
the
sc_prim_channel_thread_safety
branch
3 times, most recently
from
eaaf4d6 to
7d219e6
Compare
Use a std::atomic to handle the time_resolution_fixed flag in the kernel, tracking whether the time resolution has been set or non-zero sc_time objects have been constructed. Signed-off-by: Philipp A. Hartmann <pah@apple.com>
Signed-off-by: Philipp A. Hartmann <pah@apple.com>
Signed-off-by: Philipp A. Hartmann <pah@apple.com>
Signed-off-by: Mark Burton <mburton@quicinc.com>
Align async_event example code with the scp_async_event as it's cleaner Prevent race condition on startup in sc_suspend test Signed-off-by: Mark Burton <mburton@quicinc.com>
Signed-off-by: Mark Burton <mburton@quicinc.com>
markfoodyburton
force-pushed
the
sc_prim_channel_thread_safety
branch
from
7d219e6 to
29717f2
Compare
maehne
approved these changes
Nov 25, 2024
lmailletcontoz
merged commit 935c59e
into
accellera-official:main
41 of 80 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the mutex to 'pending' and removed it from the attach detach functions, which should not need it as they are not marked as thread safe, so should be called from the systemc thread.