Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform distribution support for crave vairables #10

Merged
merged 15 commits into from
Apr 5, 2023
Merged

Uniform distribution support for crave vairables #10

merged 15 commits into from
Apr 5, 2023

Conversation

voertler
Copy link
Contributor

Make crave variables default uniform distributed over their value range (alignment to SystemVerilog default behavior))

@basarts basarts requested a review from hvdschoot September 7, 2022 15:48
This was referenced Sep 8, 2022
Copy link

@hvdschoot hvdschoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the uniform distribution fix, and see it behaving favorably in that I now indeed get random values for crave variables that do not have constraints on them. That said, I do still run into quite some issues overall, with certain constraints seemingly not working, or not being solved properly, or not being solvable by the (Z3) solver, and other such related peculiar things, too convoluted to list here. The worst is, getting a segmentation fault during the solver process appears more the rule than the exception.

I will need to find a proper yet non-laborious way of communicating these various issues, which won't be easy as my observations are all over the place and it is challenging to get my head around it. I'll have to see to what extent I can create examples of misbehavior, but I'd first rather start with a review meeting for instance with Thilo going over some of my Crave code to discuss what I am aiming to do. Extracting small non-proprietary examples out of this such that these examples also fail is ptentially a big job, which may be significantly short-cut by a review meeting first.

@SchulzSt
Copy link
Contributor

VWG: related to #4

@SchulzSt
Copy link
Contributor

SchulzSt commented Mar 22, 2023

Coseda contribution notice missing (see also CONTRIBUTORS)

@SchulzSt SchulzSt merged commit 3a63515 into accellera-official:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants