Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Emission Analysis Project #720

Merged
merged 59 commits into from
Aug 2, 2024
Merged

Conversation

minal2577
Copy link
Contributor

@minal2577 minal2577 commented Jul 23, 2024

Pull Request for ML-Crate 💡

Issue Title:

  • Info about the related issue (Aim of the project) :
  • Name: Minal
  • Email ID for further communication: minaljain1973@gmail.com
  • GitHub ID: minal2577
  • Idenitfy yourself: Contributor in Ssoc

Closes: #500

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I have tested the notebook by running all the cells to ensure there are no errors. Each step in the notebook, from data preprocessing to policy impact simulation, was verified for correctness and functionality.

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @minal2577 :)

@minal2577
Copy link
Contributor Author

Good evening,

I have created a project for issue #500 using air and climate data. In this project, I refined the data and applied the algorithms as discussed. However, I believe that the model would benefit from further data training to improve its accuracy and performance.

Best regards,
minal(minal2577)

@minal2577 minal2577 closed this Jul 23, 2024
@minal2577 minal2577 reopened this Jul 23, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the project structure and put your files as per the structure. You need to create a single project folder as "Global Emission Analysis", inside that you need to create Model, Images, Dataset folders and put the files as per their folder specifications.
@minal2577

@abhisheks008
Copy link
Owner

Pull Request for ML-Crate 💡

Issue Title:

  • Info about the related issue (Aim of the project) :
  • Name: <!--Minal->
  • Email ID for further communication:
  • GitHub ID:
  • Idenitfy yourself:

Closes: #500

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I have tested the notebook by running all the cells to ensure there are no errors. Each step in the notebook, from data preprocessing to policy impact simulation, was verified for correctness and functionality.

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Please fill up this template while you are creating a pull request. This will help me to understand the contributor and the issue details.

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jul 24, 2024
@minal2577 minal2577 requested a review from abhisheks008 July 24, 2024 17:39
@minal2577 minal2577 marked this pull request as draft July 24, 2024 17:40
@minal2577
Copy link
Contributor Author

Sir i have made asked changes please tell me if any another change is needed

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @minal2577 looks good to me. Approved ✅

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Aug 2, 2024
@abhisheks008 abhisheks008 merged commit f367e1e into abhisheks008:main Aug 2, 2024
@abhisheks008
Copy link
Owner

abhisheks008 commented Aug 3, 2024

@minal2577 how many times should I inform you to update your details as per the pull request, I have mentioned twice to fill up the details still you are acting carelessly, without your details how can I add your points in the system?

@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Aug 3, 2024
@minal2577
Copy link
Contributor Author

Sir i have already done it from my side may be there is a technical issue it shows from my side its done

@abhisheks008
Copy link
Owner

@minal2577 put your details as per the template in the comments.

@minal2577
Copy link
Contributor Author

Done sir see if you are able to see it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Environmental Indicators Analysis
2 participants