Poker Hand Prediction

[aviralgarg05]

Pull Request for ML-Crate 💡

Issue Title: Poker Hand Prediction

• Info about the related issue (Aim of the project) : Predict Poker Hand
• Name: Aviral Garg
• Email ID for further communication: gargaviral99@gmail.com
• GitHub ID: aviralgarg05
• Idenitfy yourself: SSOC Contributor

Closes: #issue number that will be closed through this PR
#693

Describe the add-ons or changes you've made 📃

NA
Give a clear description of what have you added or modifications made
NA

Type of change ☑️

What sort of change have you made:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, local variables)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested: Previous Test Datasets
Describe how have you verified the changes made:- Accuracy Scores

Checklist: ☑️

• My code follows the guidelines of this project.
• I have performed a self-review of my own code.
• I have commented my code, particularly wherever it was hard to understand.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have added things that prove my fix is effective or that my feature works.
• Any dependent changes have been merged and published in downstream modules.

[github-actions]

Our team will soon review your PR. Thanks @aviralgarg05 :)

[abhisheks008]

You have created duplicate folders inside the project folder. Please go through them and make them arranged.

@aviralgarg05

[aviralgarg05]

Ok I will edit them out

[abhisheks008]

Still the duplicate files are present in the project folder. Also use a generalized Jupyter Notebook file instead of separate .py files for each of the algorithms. Create an .ipynb file and do the EDA, model training, model implementations one after another. That'll be easier to understand for any one.

[aviralgarg05]

Still the duplicate files are present in the project folder. Also use a generalized Jupyter Notebook file instead of separate .py files for each of the algorithms. Create an .ipynb file and do the EDA, model training, model implementations one after another. That'll be easier to understand for any one.

Actually those are the models that I created separately, and called them into the ipynb for visualization and testing purposes. (It was giving me some kernel issues while training the models in jupyter notebook so created them separately as .py and called them in .ipynb for testing). The files present in both the folders are completely different. Just their naming is same for identification purposes of models while calling.

[abhisheks008]

Why should we have .ipynb and .py files for each and every algorithm? These are simple machine learning algortihms I don't think these will take too much of the kernel for processing.

[aviralgarg05]

Why should we have .ipynb and .py files for each and every algorithm? These are simple machine learning algortihms I don't think these will take too much of the kernel for processing.

No it wasn't taking resources, but was giving me virtual environment issues while training about the libraries. So created model separately and tested separately. Actually I had been working on different project and some issues of kernel versions had been occurring.

[abhisheks008]

Hi @aviralgarg05 I got your points. But it's better to go with a single jupyter notebook file which will contain all the stuff including the EDAs, model training and model implementation.

[aviralgarg05]

What I'll do is add the entire folder to .gitignore Hence it would make the structure better. As without those files the actual prediction won't work.

[abhisheks008]

1. Follow the README template and update the README. Here it is, https://github.com/abhisheks008/ML-Crate/blob/main/.github/readme_template.md
2. Rename the .ipynb folder from "Poker Hand Prediction" to "Notebooks".

@aviralgarg05

[abhisheks008]

Looks good to me. Approved ✅
@aviralgarg05