Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank Negara Indonesia Stock Prediction #534

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

pawaspy
Copy link
Contributor

@pawaspy pawaspy commented Jan 17, 2024

Pull Request for ML-Crate 💡

Issue Title:

  • Info about the related issue (Aim of the project) :
  • Name:
  • GitHub ID:
  • Idenitfy yourself:

Closes: #501

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @pawaspy :)

@abhisheks008
Copy link
Owner

image

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Jan 17, 2024
Copy link
Contributor Author

@pawaspy pawaspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed and corrected the file. Can you review it again?

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and ready to be merged.

Please share the following details,
Name:
Email ID:

@pawaspy

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Ready To Merge 🚀 This PR is approved and ready to merge. JWOC This issue/pull request will be considered for JWOC 2k22. Intermediate Points 30 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jan 18, 2024
@pawaspy
Copy link
Contributor Author

pawaspy commented Jan 18, 2024

Name: Pawas Pandey
Email ID: pawaspy2633@gmail.com

@abhisheks008 abhisheks008 merged commit 6e38a60 into abhisheks008:main Jan 19, 2024
@abhisheks008 abhisheks008 added Points Added 🎉 This issue's points has been added to the leaderboard. and removed Ready To Merge 🚀 This PR is approved and ready to merge. labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 JWOC This issue/pull request will be considered for JWOC 2k22. Points Added 🎉 This issue's points has been added to the leaderboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bank Negara Indonesia Stock Analysis
2 participants