Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VEHICLE LIVE RISK PREDICTION #529

Merged
merged 9 commits into from
Jan 17, 2024
Merged

VEHICLE LIVE RISK PREDICTION #529

merged 9 commits into from
Jan 17, 2024

Conversation

CoderOMaster
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: VEHICLE LIVE RISK PREDICTION

  • Info about the related issue (Aim of the project) :
  • Name: <Keshav Arora
  • Idenitfy yourself: JWOC 2024

Closes: #issue number 473 that will be closed through this PR

@github-actions GitHub Actions
Copy link

Our team will soon review your PR. Thanks @CoderOMaster :)

@abhisheks008 abhisheks008 linked an issue Jan 16, 2024 that may be closed by this pull request
Vehicle Live Risk Prediction #473
Closed
abhisheks008
abhisheks008 requested changes Jan 16, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Put all the EDA results in the Images folder.
  2. Can you implement Lasso, Ridge, XgBoost, Gradient Boosting and MLP in this dataset? That'll be a better comparison and model implementation showcase.

@CoderOMaster

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Jan 16, 2024
@CoderOMaster
Copy link
Contributor Author

Hi @abhisheks008
I will put all eda images and also show one more algorithm since as described in detail that dataset is too perfect for any model to handle.I have reached this conclusion on extensive filtering.
Thank You

@abhisheks008
Copy link
Owner

Hi @abhisheks008 I will put all eda images and also show one more algorithm since as described in detail that dataset is too perfect for any model to handle.I have reached this conclusion on extensive filtering. Thank You

I know it's not achieve good scores always. If you implement all the mentioned models, others can benefit from this while going through your project, if someone wants to know more about the model implementation on a same dataset.

@CoderOMaster
Copy link
Contributor Author

@abhisheks008 I have implemented all and xgboost in another notebook separately due to some detection issue in garuda linux.All images are added too for eda.I would like to request you that please consider this as hard problem since it took lot of analysis to conclude.

abhisheks008
abhisheks008 requested changes Jan 16, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes related to documentation.
@CoderOMaster

This will be marked as Hard label, don't worry, your efforts will get the value as well.

Vehicle Live Risk Prediction/README.md

These sample images show relationship of columns with each other(more detail in notebook 1 with EDA)

**MODELS USED**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the model names as per the recent upgrade.

Vehicle Live Risk Prediction/README.md
4) MATPLOTLIB
5) SEABORN

**IMPLEMENTATION**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this too.

Vehicle Live Risk Prediction/README.md
4) 50+ risk_score was considered as parameter for accident risk,whereas less than value signified no risk of accident.
4) Different notebooks with different models were used for clear and concise display of information for mentor.

**RESULT**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the results section too. It's better to create a table like this,

Models implemented Accuracy scores
Random Forest 99%
... ...
... ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done sir

abhisheks008
abhisheks008 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
@CoderOMaster

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Advanced Points 40 - SSOC 2024 JWOC This issue/pull request will be considered for JWOC 2k22. and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jan 17, 2024
@abhisheks008 abhisheks008 merged commit f57d700 into abhisheks008:main Jan 17, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jan 17, 2024
@abhisheks008
Copy link
Owner

Please share your email ID for further communication.
@CoderOMaster

@CoderOMaster
Copy link
Contributor Author

@abhisheks008
e-mail: keshavarorasci@gmail.com
Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhisheks008 abhisheks008 abhisheks008 approved these changes

Assignees

@CoderOMaster CoderOMaster

Labels
Advanced Points 40 - SSOC 2024 Approved ✅ This PR is approved by the PR or, Mentors. JWOC This issue/pull request will be considered for JWOC 2k22. Points Added 🎉 This issue's points has been added to the leaderboard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vehicle Live Risk Prediction
2 participants
@CoderOMaster @abhisheks008