Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eurovision Song Contest Analysis #482

Merged
merged 12 commits into from
Jan 5, 2024
Merged

Eurovision Song Contest Analysis #482

merged 12 commits into from
Jan 5, 2024

Conversation

mariam7084
Copy link
Contributor

@mariam7084 mariam7084 commented Jan 3, 2024 •
edited
Loading

Pull Request for ML-Crate 💡

Issue Title: Eurovision Song Contest Analysis

  • Info about the related issue (Aim of the project) : To perform Exploratory Data Analysis on the given dataset and derive meaningful conclusions
  • Name: Mariam
  • GitHub ID: https://github.com/mariam7084
  • Idenitfy yourself: KWoC

Closes: #396

Describe the add-ons or changes you've made 📃

made changes in the .ipynb file by performing more analysis on the data and plotting graphs as suggested in the "requested Changes".

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • [x ] Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

ran the code on both colab and local pc to verify the that it works perfectly fine

Checklist: ☑️

  • [ x] My code follows the guidelines of this project.
  • [x ] I have performed a self-review of my own code.
  • [x ] I have commented my code, particularly wherever it was hard to understand.
  • [x ] I have made corresponding changes to the documentation.
  • [ x] My changes generate no new warnings.
  • [x ] I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Our team will soon review your PR. Thanks @mariam7084 :)

@mariam7084 mariam7084 closed this Jan 3, 2024
@mariam7084 mariam7084 reopened this Jan 3, 2024
@mariam7084 mariam7084 changed the title PR after performing the requested changes PR after performing the requested changes 'Eurovision Song Contest Analysis' Jan 4, 2024
@abhisheks008 abhisheks008 changed the title PR after performing the requested changes 'Eurovision Song Contest Analysis' Eurovision Song Contest Analysis Jan 4, 2024
abhisheks008
abhisheks008 requested changes Jan 4, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mariam7084 please follow the README.md template and update the project README file accordingly.

Here is the template, https://github.com/abhisheks008/ML-Crate/blob/main/.github/readme_template.md

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Jan 4, 2024
abhisheks008
abhisheks008 reviewed Jan 4, 2024
View reviewed changes
Eurovision Song Contest Analysis/Model/README.md
3. Seaborn
4. NumPy

**VISUALIZATION**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your EDA/Visualization outputs under this Visualization heading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the images.

abhisheks008
abhisheks008 reviewed Jan 4, 2024
View reviewed changes
Eurovision Song Contest Analysis/Model/README.md Outdated

**CONCLUSION**

100 points were scored the most number of times. The contest was not held in the year 2020 as is evident from the "Total Points scored over the years" plot. The graph also tells that the total points scored over the years have increased significantly with being less than 100 before 1970 and well over 400 after 2010.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bullet points or numbering lists, it'll look better than this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrote the conclusion in bullet points

abhisheks008
abhisheks008 reviewed Jan 4, 2024
View reviewed changes
Eurovision Song Contest Analysis/Model/README.md Outdated
@@ -0,0 +1,45 @@


**Eurovision Song Contest Anlaysis**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the <h1> tag for the project name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

abhisheks008
abhisheks008 requested changes Jan 4, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix some documentation related minor changes.
@mariam7084

@mariam7084
Update README.md
a61e187
@mariam7084
Updated README.md
d1aabb5 
added images and converted conclusion to bullet points
@mariam7084
Updated README.md
34a4656
@mariam7084
Copy link
Contributor Author

Fixed all the issues in the README.md file. @abhisheks008

abhisheks008
abhisheks008 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfectly done! Your PR is approved and ready to be merged.
@mariam7084

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jan 5, 2024
@abhisheks008 abhisheks008 merged commit 7462e95 into abhisheks008:main Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhisheks008 abhisheks008 abhisheks008 approved these changes

Assignees

@mariam7084 mariam7084

Labels
Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eurovision Song Contest Analysis
2 participants
@mariam7084 @abhisheks008