Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lottery Prediction #455

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Lottery Prediction #455

merged 1 commit into from
Dec 20, 2023

Conversation

pawaspy
Copy link
Contributor

@pawaspy pawaspy commented Dec 19, 2023

Pull Request for ML-Crate 💡

Issue Title:

  • Info about the related issue (Aim of the project) :
  • Name:
  • GitHub ID:
  • Idenitfy yourself:

Closes: #issue number that will be closed through this PR

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @pawaspy :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the Consumer_Price_Prediction.ipynb file.
  • Fill up the pull request template properly with all the required credentials.

@pawaspy

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Dec 20, 2023
Copy link
Contributor Author

@pawaspy pawaspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the consumer price prediction file

@abhisheks008 abhisheks008 linked an issue Dec 20, 2023 that may be closed by this pull request
3 tasks
@abhisheks008 abhisheks008 changed the title Lottery Lottery Prediction Dec 20, 2023
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Your PR is approved and ready to be merged.
@pawaspy

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Dec 20, 2023
@abhisheks008 abhisheks008 merged commit b9160a3 into abhisheks008:main Dec 20, 2023
@pawaspy pawaspy deleted the lottery branch December 20, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lottery Prediction
2 participants