-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker container #175
base: development
Are you sure you want to change the base?
Docker container #175
Conversation
@Sarthak027 is attempting to deploy a commit to the Abhijeet's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Sarthak027! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an optimized docker file, it will result in more size and more resource usage.
Replace with the next.js official documentation. visit https://github.com/vercel/next.js/tree/canary/examples/with-docker you will get the dockerfile with steps to step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave the server dockerfile as i already added and it's optimized also.
Hey @Sarthak027, i have reviewed the code at high level, do the required changes then i will test the code. |
Also update the readme file, how to run using docker. |
Fixes #38