Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container #175

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

Sarthak027
Copy link
Contributor

@Sarthak027 Sarthak027 commented Jun 13, 2024

Fixes #38

Copy link

vercel bot commented Jun 13, 2024

@Sarthak027 is attempting to deploy a commit to the Abhijeet's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Sarthak027! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an optimized docker file, it will result in more size and more resource usage.

Replace with the next.js official documentation. visit https://github.com/vercel/next.js/tree/canary/examples/with-docker you will get the dockerfile with steps to step.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the server dockerfile as i already added and it's optimized also.

@abhijeetnishal
Copy link
Owner

Hey @Sarthak027, i have reviewed the code at high level, do the required changes then i will test the code.

@abhijeetnishal abhijeetnishal changed the base branch from master to development June 15, 2024 15:17
@abhijeetnishal
Copy link
Owner

Also update the readme file, how to run using docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implementation of Docker Containerization for the Application
2 participants