Code modding #71
Draft
Code modding #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create an identity codemod that should in theory return the same as the input (showing roundtrippability of parsing + printing) enough to get "b.luau" parsing and printing (currently without whitespace trivia)
Introduces the necessary steps to extract and store trivia on tokens The serialization step now also stores the underlying source and a cursor through the source. When we serialize a token, we take everything in between the cursor position and the token start position and extract that as trivia. To speed up offset computation, we compute the line offsets for the file beforehand. We convert AstExprConstantString into a style of token. Right now, this serializes trivia into one big chunk. And also, it does not split trivia into leading and trailing trivia. We will probably want to split trivia into whitespace + comments. We should follow roslyn syntax rules where everything up to and including a newline character is treated as trailing trivia for the previous token, and everything after that is leading trivia for the next token. This makes code modding nicer, as we can treat nodes as discrete chunks.
We need to be careful with the order of serialization, as otherwise it can mess up the cursor and trivia tracking. This commit reorganises some of the serialization so it is in line TODO: The serialization of commas is wrong, since we do it too late. This is going to cause an assertion failure once we hit an example that is comma separated
This better handles serialization of separators and related trivia
We can also reuse a visitor to print a node, by just printing all tokens
Enough to get the json.luau file working
Enough to parse the writeFile test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luau has CST nodes 🤔