Add '/promote' Command

- Fix a bug where the wrong message was sent to players who join.
- Add a '/promote [<player>]' command that is an alias of the '/prom update <player_default_target> [<player>]' command.
- Update the help command.
- Remove some unnecessary comments.

PromoteOneself/Information.txt

@@ -1,4 +1,4 @@
-This is a general plugin information file that is shipped inside the exported .jar file of the plugin. More information can be found on this plugin's GitHub page. This file was last updated for plugin version 1.0.0.2. 
+This is a general plugin information file that is shipped inside the exported .jar file of the plugin. More information can be found on this plugin's GitHub page. This file was last updated for plugin version 1.0.0.3. 
 
 
 Commands: 

PromoteOneself/plugin.yml

@@ -1,6 +1,6 @@
 name: PromoteOneself
 main: me.PromoteOneselfPackage.PromoteOneself.Classes.PromoteOneselfMainClass 
-version: 1.0.0.2
+version: 1.0.0.3
 description: A plugin which lets people achieve aims to work up through a server's ranking system 
 author: aappleton3 
 database: false
@@ -9,6 +9,9 @@ commands:
   promoteoneself:
     description: Command to show the command for help 
     usage: /promoteoneself 
+  promote:
+    description: An alternative form of the command /prom update <default_next_target> [<player>] 
+    usage: /promote [<player>]
   prom: 
     description: Commands that update a player's status 
     usage: /prom <arguments> 

PromoteOneself/src/me/PromoteOneselfPackage/PromoteOneself/Classes/CommandHelp.java

@@ -35,6 +35,7 @@ public void helpPages(CommandSender sender, int page) {
 			sender.sendMessage(ChatColor.AQUA + "/posset reload [argument]" + ChatColor.WHITE + " - Reload the plugin's configuration files "); 
 			sender.sendMessage(ChatColor.AQUA + "/posset player <arguments>" + ChatColor.WHITE + " - Reset, add or remove a player in, to or from the promotion tree "); 
 			sender.sendMessage(ChatColor.AQUA + "/posset set <arguments>" + ChatColor.WHITE + " - Set various values for players, aim, targets and settings "); 
+			sender.sendMessage(ChatColor.AQUA + "/promote [<player>]" + ChatColor.WHITE + " - An alias of " + ChatColor.AQUA + "/prom update <default_next_target> [<player>] ");
 		}
 	}
 	public void helpCommand(CommandSender sender, String command, String firstArgument) {

PromoteOneself/src/me/PromoteOneselfPackage/PromoteOneself/Classes/MyPlayerListener.java

@@ -63,11 +63,11 @@ else if (plugin.yc.configuration.getBoolean("startInPromotionTree") == true) {
 			ua.addPlayer(defaultFirstTarget, spId, rpId, true); 
 		}
 		if ((exempt == false) && plugin.yc.configuration.getBoolean("remindOnJoin")) {
-			if (plugin.yd.configuration.getBoolean("players." + spId + ".finished") == true) {
+			if (plugin.yd.configuration.getBoolean("players." + spId + ".finished") == false) {
 				String target = plugin.yd.configuration.getString("players." + spId + ".target"); 
 				Bukkit.getPlayer(rpId).sendMessage(ChatColor.AQUA + plugin.logger.getName(true) + "Your current target (" + target + ") requires the aims: " + plugin.yc.configuration.getStringList("targets." + target + ".aims"));
 			}
-			else if (plugin.yd.configuration.getBoolean("players." + spId + ".finished") == false) {
+			else if (plugin.yd.configuration.getBoolean("players." + spId + ".finished") == true) {
 				Bukkit.getPlayer(rpId).sendMessage(ChatColor.GREEN + plugin.logger.getName(true) + "You have obtained the highest self-promotion possible. "); 
 			}
 			else {

PromoteOneself/src/me/PromoteOneselfPackage/PromoteOneself/Classes/PromoteOneselfMainClass.java

@@ -4,10 +4,10 @@
 import java.util.Set;
 
 import org.bukkit.ChatColor;
-//import org.bukkit.Bukkit;
 import org.bukkit.command.Command;
+import org.bukkit.command.CommandExecutor;
 import org.bukkit.command.CommandSender;
-//import org.bukkit.entity.Player;
+import org.bukkit.entity.Player;
 import org.bukkit.plugin.Plugin;
 import org.bukkit.plugin.PluginManager;
 import org.bukkit.plugin.RegisteredServiceProvider;
@@ -18,7 +18,7 @@
 
 import org.black_ixx.playerpoints.PlayerPoints; 
 
-public class PromoteOneselfMainClass extends JavaPlugin{ 
+public class PromoteOneselfMainClass extends JavaPlugin implements CommandExecutor { 
 	public static PromoteOneselfMainClass plugin; 
 
 	public final LoggingClass logger = new LoggingClass(this, "Minecraft"); 
@@ -127,7 +127,24 @@ public void saveConfig() {
 	}
 
 	public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
-		if (commandLabel.equalsIgnoreCase("promoteoneself")) {
+		if (commandLabel.equalsIgnoreCase("promote")) {
+			if (args.length == 0) {
+				if (sender instanceof Player) {
+					ua.promoteCommand(sender, ((Player)sender).getName());
+				}
+				else {
+					logger.messageSender(sender, "wrongarrangement", ""); 
+				}
+			}
+			else if (args.length == 1) {
+				ua.promoteCommand(sender, args[0]); 
+			}
+			else {
+				logger.messageSender(sender, "help", null); 
+				return false; 
+			}
+		}
+		else if (commandLabel.equalsIgnoreCase("promoteoneself")) {
 			ch.helpPages(sender); 
 		}
 		else if (commandLabel.equalsIgnoreCase("prom")) {

PromoteOneself/src/me/PromoteOneselfPackage/PromoteOneself/Classes/UpdateAims.java

@@ -726,15 +726,12 @@ else if (plugin.yc.configuration.getString("aims." + i + ".type").equalsIgnoreCa
 				player.sendMessage("Your target is now " + nextTarget); 
 			}
 			if (runTheCommands == false) {
-				//sender.sendMessage("runTheCommands == false"); 
 				// No action required 
 			}
 			else if (plugin.yc.configuration.getString("targets." + target + ".commands").equalsIgnoreCase("none")) {
-				//sender.sendMessage("As a string, no commands"); 
 				// No action required 
 			}
 			else if (plugin.yc.configuration.getStringList("targets." + target + ".commands").get(0).equalsIgnoreCase("none")) { 
-				//sender.sendMessage("As a list, no commands"); 
 				// No action required 
 			} 
 			else {
@@ -748,4 +745,24 @@ else if (plugin.yc.configuration.getStringList("targets." + target + ".commands"
 			sender.sendMessage(ChatColor.RED + "The specified target is not a valid target to progress to "); 
 		}
 	}
+
+	public void promoteCommand(CommandSender sender, String playerName) {
+		@SuppressWarnings("deprecation")
+		Player player = Bukkit.getPlayer(playerName);  
+		if (player == null) {
+			logger.messageSender(sender, "offline", ", it could be offline "); 
+		}
+		else {
+			UUID rpId = player.getUniqueId(); 
+			String spId = rpId.toString();
+			if (plugin.yc.configuration.contains("players." + spId)) {
+				String nextTarget = plugin.yc.configuration.getString("targets." + plugin.yd.configuration.getString("players." + spId + ".target") + ".defaultNextTarget"); 
+				String[] args = { "update", nextTarget, playerName }; 
+				updatePlayer(sender, args); 
+			}
+			else {
+				logger.messageSender(sender, "noplayer", playerName); 
+			}
+		}
+	}
 }

README.md

@@ -51,6 +51,7 @@ This plugin contains the following commands:
  - /promoteoneself
  - /prom <arguments> 
  - /posset <arguments> 
+ - /promote [<player>]
 
 The */promoteoneself* command shows the help page. \
 The */prom help [<page>]* command shows the top level help pages. \
@@ -89,7 +90,8 @@ The */posset set setting updateUsernames true|false* command sets whether the pl
 The */posset set setting defaultPoints <integer>* command sets the default number of points players should have. \
 The */posset set setting alwaysSaveFiles true|false* command sets whether configuration files the plugin couldn't load properly should be saved regardless (this may wipe the files). \
 The */posset set setting remindOnJoin true|false* command sets whether the plugin should send a reminder to players each time they join. \
-The */posset set sign <sign-id> usage <integer>* command sets the maximum usage allowed by a sign. 
+The */posset set sign <sign-id> usage <integer>* command sets the maximum usage allowed by a sign. \
+The */promote [<player>]* command is an alias of the */prom update <player_default_next_target> [<player>]* command. 
 
 Where applicable, commands of the form */prom update <arguments>*, */posset player <arguments>*, */posset exempt &ltarguments>* and */posset set player <arguments>* only work for players which are currently online.