Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate pdf button overlap #17

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

nirvedh-harpal
Copy link
Contributor

@nirvedh-harpal nirvedh-harpal commented Feb 11, 2025

Fixed Issue : #10

What Changed?

  • Updated the button container positioning from fixed to sticky.
  • Applied flexbox styling to ensure proper center alignment of the button.

Why is this Change Required?

  • Previously, the "Generate PDF" button overlapped the footer, impacting usability.
  • Using sticky positioning ensures the button remains visible while scrolling without obstructing the footer, enhancing the user experience.

Before:

image

After :

image
image

@aafre aafre added bug Something isn't working Frontend labels Feb 11, 2025
@aafre
Copy link
Owner

aafre commented Feb 11, 2025

@nirvedh-harpal Please unmark from draft when ready.

@nirvedh-harpal nirvedh-harpal marked this pull request as ready for review February 12, 2025 04:44
@aafre
Copy link
Owner

aafre commented Feb 12, 2025

Looks good, thanks for contributing.

@aafre aafre merged commit 2369a5e into aafre:main Feb 12, 2025
1 check passed
@aafre aafre self-requested a review February 12, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants