Skip to content

Commit

Permalink
fix condition for saving source image
Browse files Browse the repository at this point in the history
  • Loading branch information
mhwasil committed Apr 23, 2024
1 parent b2e8715 commit a5c0132
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/docker-build-test-upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
variant: ${{ inputs.parent-variant }}

# Source/initial image is always based on jupyter/pytorch-notebook
- name: Source image 📥
- name: Pull source image 📥
if: inputs.parent-image == ''
run: docker pull quay.io/jupyter/${{ inputs.image }}:${{ inputs.variant }}
shell: bash
Expand All @@ -97,17 +97,18 @@ jobs:
BUILDKIT_PROGRESS: plain
shell: bash

- name: Save image as a tar for later use 💾
if: inputs.parent-image != ''
- name: Save source image as a tar for later use 💾
if: inputs.parent-image == ''
run: |
mkdir -p /tmp/a2s/images/
docker save ${{ env.REGISTRY }}/${{ env.OWNER }}/${{ inputs.image }}:${{ inputs.variant }} | zstd > /tmp/a2s/images/${{ inputs.image }}--${{ inputs.variant }}.tar.zst
docker save quay.io/jupyter/${{ inputs.image }}:${{ inputs.variant }} | zstd > /tmp/a2s/images/${{ inputs.image }}--${{ inputs.variant }}.tar.zst
shell: bash

- name: Save source image as a tar for later use 💾
- name: Save image as a tar for later use 💾
if: inputs.parent-image != ''
run: |
mkdir -p /tmp/a2s/images/
docker save quay.io/jupyter/${{ inputs.image }}:${{ inputs.variant }} | zstd > /tmp/a2s/images/${{ inputs.image }}--${{ inputs.variant }}.tar.zst
docker save ${{ env.REGISTRY }}/${{ env.OWNER }}/${{ inputs.image }}:${{ inputs.variant }} | zstd > /tmp/a2s/images/${{ inputs.image }}--${{ inputs.variant }}.tar.zst
shell: bash

- name: Upload image as artifact 💾
Expand Down

0 comments on commit a5c0132

Please sign in to comment.