Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/3.13.0 #246

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Release/3.13.0 #246

merged 1 commit into from
Feb 11, 2025

Conversation

JesusMcCloud
Copy link
Collaborator

  • Fix COSE key serialization
  • Refactor Asn1Integer to use UByteArray internally instead of a list
  • Fix ASN.1 decoding flaw for a very specific length encoding
  • Performance optimization: Instantiate fewer KmmResults
  • Move PemEncodable/PemDecodable from indispensable to indispensable-asn1 module.
  • More comprehensive PEM encoding/decoding support:
    • CryptoPublicKey
      • Note that PKCS1 encoding of RSA keys is not supported as it is discouraged (decoding is supported)
      • ANSI encoding and decoding is also unsupported, because decoding requires context and encoding this way is incomplete
    • X509Certificate
    • CSR (Pkcs10CertificationRequest)
  • Change CoseHeader.certificateChain (CBOR element 33 x5chain) from a single byte array to a list of byte arrays, acc. to specification
  • Remove CoseHeader.coseKey, which has been an unofficial addition from OID4VCI, but has been removed since

* Fix COSE key serialization
* Refactor `Asn1Integer` to use `UByteArray` internally instead of a list
* Fix ASN.1 decoding flaw for a very specific length encoding
* Performance optimization: Instantiate fewer `KmmResults`
* Move `PemEncodable`/`PemDecodable` from _indispensable_ to _indispensable-asn1_ module.
* More comprehensive PEM encoding/decoding support:
    * `CryptoPublicKey`
      * Note that PKCS1 encoding of RSA keys is not supported as it is discouraged (decoding is supported)
      * ANSI encoding and decoding is also unsupported, because decoding requires context and encoding this way is incomplete
    * `X509Certificate`
    * CSR (`Pkcs10CertificationRequest`)
* Change `CoseHeader.certificateChain` (CBOR element 33 `x5chain`) from a single byte array to a list of byte arrays, acc. to specification
* Remove `CoseHeader.coseKey`, which has been an unofficial addition from OID4VCI, but has been removed since
@JesusMcCloud JesusMcCloud requested a review from nodh February 11, 2025 12:42
Copy link

⚠️⚠️ This pull request targets main. I am re-targeting it to development. ⚠️⚠️

@github-actions github-actions bot changed the base branch from main to development February 11, 2025 12:42
@JesusMcCloud JesusMcCloud merged commit bd5c269 into development Feb 11, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants